Differential D27177

Add .cfi_{start,end}proc for RISC-V assembly functions
ClosedPublic
Actions

Authored by arichardson on Nov 11 2020, 12:33 PM.

Tags

None

Referenced Files

	F150837854: D27177.id80026.diff
	Sat, Apr 4, 9:54 AM

	Unknown Object (File)
	Mon, Mar 30, 3:48 PM

	Unknown Object (File)
	Fri, Mar 27, 4:29 AM

	Unknown Object (File)
	Sun, Mar 22, 4:37 PM

	Unknown Object (File)
	Sun, Mar 22, 1:39 PM

	Unknown Object (File)
	Sun, Mar 22, 11:03 AM

	Unknown Object (File)
	Sun, Mar 22, 4:47 AM

	Unknown Object (File)
	Thu, Mar 19, 10:42 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rS368070: Add .cfi_{start,end}proc for RISC-V assembly functions

Summary

This allows GDB to print more useful backtraces when setting a breakpoint
on an assembly function.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson requested review of this revision.Nov 11 2020, 12:33 PM

arichardson created this revision.

Harbormaster completed remote builds in B34741: Diff 79426.Nov 11 2020, 12:33 PM

jhb accepted this revision.Nov 16 2020, 11:47 PM

This revision is now accepted and ready to land.Nov 16 2020, 11:47 PM

Closed by commit rS368070: Add .cfi_{start,end}proc for RISC-V assembly functions (authored by arichardson). · Explain WhyNov 26 2020, 5:37 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS368070: Add .cfi_{start,end}proc for RISC-V assembly functions.

Herald added a subscriber: imp. · View Herald TranscriptNov 26 2020, 5:37 PM

We should probably do something similar for arm/mips/i386/ppc. (Of course, I am a hypocrite here; I did the same for only amd64 in rS353959.)

In D27177#611740, @cem wrote:

We should probably do something similar for arm/mips/i386/ppc. (Of course, I am a hypocrite here; I did the same for only amd64 in rS353959.)

See D27088 for mips.

I just posted https://reviews.freebsd.org/D27387 for i386/ppc/arm64 as well.

Revision Contents
Changeset List

Path

Size

head/

sys/

riscv/

include/

4 lines

Diff 80026

head/sys/riscv/include/asm.h

Loading...