Page MenuHomeFreeBSD

[PowerPC] Add .iplt to powerpc linker scripts
AcceptedPublic

Authored by bdragon on Dec 14 2019, 11:53 PM.
Referenced Files
Unknown Object (File)
Tue, Nov 4, 3:34 AM
Unknown Object (File)
Mon, Nov 3, 11:23 PM
Unknown Object (File)
Thu, Oct 30, 11:57 PM
Unknown Object (File)
Tue, Oct 28, 8:48 AM
Unknown Object (File)
Sat, Oct 25, 12:22 AM
Unknown Object (File)
Tue, Oct 21, 10:44 PM
Unknown Object (File)
Tue, Oct 14, 11:33 PM
Unknown Object (File)
Sun, Oct 12, 1:42 PM

Details

Summary

In some situations, the link editor needs to generate a secondary PLT table for ifuncs, which is initialized by .rela.dyn R_PPC_IRELATIVE relocs instead of .rela.plt R_PPC_JMP_SLOT relocs.

Ensure the .iplt section is emitted to prevent future confusion when we start using ifuncs in powerpc kernels.

Noticed while discussing https://reviews.llvm.org/D71509 with meowray in IRC.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This revision is now accepted and ready to land.Jan 22 2020, 5:56 PM

Is this still needed? We've had ifuncs for a year now, with no problems.

It ended up being not entirely necessary due to the linker behavior of forcing required sections into whatever segment is a natural fit for them, unless we explicitly break it with /DISCARD/.