Page MenuHomeFreeBSD

[PowerPC] Add .iplt to powerpc linker scripts
AcceptedPublic

Authored by bdragon on Dec 14 2019, 11:53 PM.
Referenced Files
Unknown Object (File)
Mon, Aug 24, 9:32 AM
Unknown Object (File)
Sat, Aug 22, 11:20 AM
Unknown Object (File)
Thu, Aug 20, 12:30 PM
Unknown Object (File)
Tue, Aug 11, 12:27 PM
Unknown Object (File)
Tue, Aug 11, 9:47 AM
Unknown Object (File)
Mon, Aug 10, 3:41 AM
Unknown Object (File)
Sun, Aug 9, 7:06 AM
Unknown Object (File)
Sat, Aug 8, 6:42 PM

Details

Summary

In some situations, the link editor needs to generate a secondary PLT table for ifuncs, which is initialized by .rela.dyn R_PPC_IRELATIVE relocs instead of .rela.plt R_PPC_JMP_SLOT relocs.

Ensure the .iplt section is emitted to prevent future confusion when we start using ifuncs in powerpc kernels.

Noticed while discussing https://reviews.llvm.org/D71509 with meowray in IRC.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This revision is now accepted and ready to land.Jan 22 2020, 5:56 PM

Is this still needed? We've had ifuncs for a year now, with no problems.

It ended up being not entirely necessary due to the linker behavior of forcing required sections into whatever segment is a natural fit for them, unless we explicitly break it with /DISCARD/.