Page MenuHomeFreeBSD

fbsd-phab_maskray.me (Fangrui Song)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 27 2018, 2:48 AM (143 w, 10 h)

Recent Activity

Feb 15 2021

fbsd-phab_maskray.me added inline comments to D24366: Align initial-exec TLS segments to the p_vaddr % align..
Feb 15 2021, 4:53 AM

Jan 31 2021

fbsd-phab_maskray.me added inline comments to D24366: Align initial-exec TLS segments to the p_vaddr % align..
Jan 31 2021, 5:48 PM
pi renamed fbsd-phab_maskray.me from i_maskray.me to fbsd-phab_maskray.me.
Jan 31 2021, 5:42 PM

Jan 29 2021

fbsd-phab_maskray.me added inline comments to D24366: Align initial-exec TLS segments to the p_vaddr % align..
Jan 29 2021, 8:23 PM

Oct 6 2020

fbsd-phab_maskray.me accepted D26647: Implement ptsname_r..
Oct 6 2020, 11:47 PM

Oct 4 2020

fbsd-phab_maskray.me accepted D26647: Implement ptsname_r..
Oct 4 2020, 5:24 AM

Oct 3 2020

fbsd-phab_maskray.me accepted D26647: Implement ptsname_r..
Oct 3 2020, 6:09 AM
fbsd-phab_maskray.me added inline comments to D26647: Implement ptsname_r..
Oct 3 2020, 4:29 AM

Sep 8 2020

fbsd-phab_maskray.me updated the summary of D26352: Don't allow strong symbols to override weak ones for lookups.
Sep 8 2020, 3:41 AM
fbsd-phab_maskray.me updated the diff for D26352: Don't allow strong symbols to override weak ones for lookups.

Fix all STB_WEAK occurrences

Sep 8 2020, 3:38 AM

Sep 7 2020

fbsd-phab_maskray.me added a comment to D26352: Don't allow strong symbols to override weak ones for lookups.
In D26352#585872, @kib wrote:

This breaks FreeBSD. If you look at the deleted block, the deleted comment explains why (and this is only one instance of it, there are more).

Sep 7 2020, 6:41 PM
fbsd-phab_maskray.me updated the summary of D26352: Don't allow strong symbols to override weak ones for lookups.
Sep 7 2020, 5:40 PM
fbsd-phab_maskray.me updated the summary of D26352: Don't allow strong symbols to override weak ones for lookups.
Sep 7 2020, 5:39 PM
fbsd-phab_maskray.me added reviewers for D26352: Don't allow strong symbols to override weak ones for lookups: kib, bdragon, kan.
Sep 7 2020, 5:37 PM
fbsd-phab_maskray.me updated the summary of D26352: Don't allow strong symbols to override weak ones for lookups.
Sep 7 2020, 5:36 PM
fbsd-phab_maskray.me updated the summary of D26352: Don't allow strong symbols to override weak ones for lookups.
Sep 7 2020, 5:36 PM
fbsd-phab_maskray.me updated the summary of D26352: Don't allow strong symbols to override weak ones for lookups.
Sep 7 2020, 5:35 PM
fbsd-phab_maskray.me requested review of D26352: Don't allow strong symbols to override weak ones for lookups.
Sep 7 2020, 5:30 PM
fbsd-phab_maskray.me added a comment to D23869: amd64 atomic.h: minor codegen optimization in flag access.

This has been supported since GCC 6/clang 9 (https://reviews.llvm.org/D57394). It would be better if the logic were conditioned on __GCC_ASM_FLAG_OUTPUTS__.

Sep 7 2020, 4:40 PM

Mar 21 2020

fbsd-phab_maskray.me added a comment to D24109: [LLVM][PPC32] Backport LLVM D75394.

I am hoping an administrator can change my username to something else. I don't want to expose my email address this way.

Mar 21 2020, 12:37 AM · PowerPC

Mar 4 2020

fbsd-phab_maskray.me added a comment to D23952: Link stand/i386 components using a linker script.

I really hope some administrator can change my username to something more sensible.

Mar 4 2020, 6:49 AM

Feb 23 2020

fbsd-phab_maskray.me accepted D23778: [PowerPC] Fix LLD10 linking of ofw loader on ppc.

Looks good.

Feb 23 2020, 6:43 PM · PowerPC

Sep 6 2019

fbsd-phab_maskray.me added a comment to D21163: Make p_vaddr % p_align == p_offset % p_align for TLS segments..
In D21163#465743, @kib wrote:
In D21163#464395, @i_maskray.me wrote:

...
Experiment with a few different alignments

Is that what you mean ?

diff --git a/lld/ELF/Writer.cpp b/lld/ELF/Writer.cpp
index 9db4259be49..b8b154d1f32 100644
--- a/lld/ELF/Writer.cpp
+++ b/lld/ELF/Writer.cpp
@@ -2236,12 +2236,14 @@ template <class ELFT> void Writer<ELFT>::fixSectionAlignments() {
       // p_align for dynamic TLS blocks (PR/24606), FreeBSD rtld has the same
       // bug, musl (TLS Variant 1 architectures) before 1.1.23 handled TLS
       // blocks correctly. We need to keep the workaround for a while.
+#if 0
       else if (Out::tlsPhdr && Out::tlsPhdr->firstSec == p->firstSec)
         cmd->addrExpr = [] {
           return alignTo(script->getDot(), config->maxPageSize) +
                  alignTo(script->getDot() % config->maxPageSize,
                          Out::tlsPhdr->p_align);
         };
+#endif
       else
         cmd->addrExpr = [] {
           return alignTo(script->getDot(), config->maxPageSize) +

?

Sep 6 2019, 5:56 AM
fbsd-phab_maskray.me added a comment to D21476: [PowerPC] force applications linked with lib CSU to have .got.

Can you instead add something like the following to crt1.c?

#if !defined(GCRT) && !defined(PIC)
__asm__(".text\n"
             "\t.global _GLOBAL_OFFSET_TABLE\n"
            "\t.reloc 0, R_PPC_NONE, _GLOBAL_OFFSET_TABLE_");
#endif
Sep 6 2019, 5:46 AM

Aug 21 2019

fbsd-phab_maskray.me added a comment to D21163: Make p_vaddr % p_align == p_offset % p_align for TLS segments..

Local-Exec TP offsets are link-time constants, and thus contracts between ld and ld.so. It may be worth checking if rtld-elf computed Local-Exec TP offsets match lld.

Aug 21 2019, 4:22 AM

Jul 27 2018

fbsd-phab_maskray.me added a comment to D16451: Improve --strip-trailing-cr handling.
Jul 27 2018, 3:16 AM
fbsd-phab_maskray.me accepted D16451: Improve --strip-trailing-cr handling.
Jul 27 2018, 2:51 AM