Page MenuHomeFreeBSD

release: correct VMSIZE example/documentation
ClosedPublic

Authored by gjb on Feb 27 2021, 10:38 PM.

Details

Reviewers
nwhitehorn
ehem_freebsd_m5p.com
gjb
Group Reviewers
manpages
Summary

release/release.sh originally used truncate to create empty image
files and then created filesystems in those. Now the script uses
makefs and the size specification is different. Update the sample
configuration and man page to reflect this.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 37450
Build 34339: arc lint + arc unit

Event Timeline

This is fallout from D28912/1ca8842f3ad9725863c9affc044d1974a51818a9. Problem is case differs between truncate and makefs.

Ideally there needs to be a substantial warning about this since spending hours to do a build only to have it fail just before the end is very annoying.

I should also note while the particular build failed, the build did not terminate! I suspect D28912 needs a bit of extra error checking.

Actually, there also seems to be a good argument for makefs -s being able to handle any size acceptable to truncate -s.

I've got a patch to add uppercase letters to strsufftoll(), this would make makefs accept uppercase letters and keep older configurations functioning.

We could also have makefs use expand_number(3) instead. Apologies for breakage!

This revision is now accepted and ready to land.Mar 4 2021, 1:42 PM
gjb edited reviewers, added: ehem_freebsd_m5p.com; removed: gjb.
This revision now requires review to proceed.Mar 4 2021, 1:42 PM

Thank you for the submission. In addition to your proposed patch, I have also updated the VMSIZE set in release/tools/*.conf.

This revision is now accepted and ready to land.Mar 4 2021, 2:15 PM