adridg (Adriaan de Groot)
User

Projects

User Details

User Since
Sep 11 2016, 7:14 PM (70 w, 3 d)

Recent Activity

Tue, Jan 16

adridg added a comment to D11622: Port devel/qt4-dbus to arm64.

D13935 has a patch (lifted from Fedora, it's the same one @rakuco mentioned earlier) that implements atomic ops, rather than applying a cast-hammer like this one does. See also PR 223988

Tue, Jan 16, 10:35 PM
adridg created D13935: Add aarch64 patches from Fedora.
Tue, Jan 16, 7:07 PM

Sun, Jan 14

adridg committed rP459002: Update khal to 0.9.8. Previous version was marked BROKEN due to.
Update khal to 0.9.8. Previous version was marked BROKEN due to
Sun, Jan 14, 9:23 PM
adridg closed D13432: Updating py-khal to v0.9.8.
Sun, Jan 14, 9:23 PM · Python

Fri, Jan 12

adridg added a comment to D13432: Updating py-khal to v0.9.8.

Built and installed naively it refuses to run until I set LANG to a UTF-8 locale (e.g. en_US.UTF-8), but that's more a Python 3.6 / Click problem than khal.

Fri, Jan 12, 10:15 PM · Python
adridg committed rP458879: Update deskutils/latte-dock to latest upstream release, 0.7.3.
Update deskutils/latte-dock to latest upstream release, 0.7.3
Fri, Jan 12, 9:55 PM
adridg closed D13841: Update latte-dock to latest 0.7.3 release.
Fri, Jan 12, 9:55 PM
adridg accepted D13432: Updating py-khal to v0.9.8.

OK by me, but I'd still need an OK from @tcberner or @rakuco to commit it (or they could do it themselves).

Fri, Jan 12, 9:47 PM · Python

Wed, Jan 10

adridg created D13841: Update latte-dock to latest 0.7.3 release.
Wed, Jan 10, 10:14 PM

Mon, Jan 8

adridg committed rP458483: Update www/otter-browser to latest upstream release 0.9.94.
Update www/otter-browser to latest upstream release 0.9.94
Mon, Jan 8, 9:41 PM
adridg closed D13773: Update otter-browser to latest upstream release.
Mon, Jan 8, 9:41 PM

Fri, Jan 5

adridg updated the diff for D13773: Update otter-browser to latest upstream release.

Switch to DISTVERSION

Fri, Jan 5, 9:04 PM
adridg created D13773: Update otter-browser to latest upstream release.
Fri, Jan 5, 11:21 AM
adridg closed D13769: Fix databases/soci build w/ clang..
Fri, Jan 5, 11:06 AM
adridg committed rP458126: Fix build of databases/soci w/ clang 4.0 and later and on arm6, arm7..
Fix build of databases/soci w/ clang 4.0 and later and on arm6, arm7.
Fri, Jan 5, 11:06 AM

Thu, Jan 4

adridg updated the diff for D13769: Fix databases/soci build w/ clang..

Come to think of it, if this previously compiled, the comparison
would be wrong and it's a bug which can mis-report an error.
While here, drop the BROKEN lines, since this fixes exactly that error.

Thu, Jan 4, 8:41 PM
adridg created D13769: Fix databases/soci build w/ clang..
Thu, Jan 4, 8:39 PM
adridg closed D13694: CMake 3.10 needs C++11.

This was fixed with r457650

Thu, Jan 4, 12:49 PM
adridg committed rP458026: Fix build on 10.3 i386 noticed by pkg-fallout. Patch has also been.
Fix build on 10.3 i386 noticed by pkg-fallout. Patch has also been
Thu, Jan 4, 12:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Thu, Jan 4, 12:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Thu, Jan 4, 12:46 PM
adridg committed rP458025: Switch databases/soci to <opt>_CMAKE_BOOL..
Switch databases/soci to <opt>_CMAKE_BOOL.
Thu, Jan 4, 12:46 PM
adridg updated the diff for D12957: Switch to <opt>_CMAKE_BOOL.

No need to bump PORTREVISION, cosmetic change in Makefile only.

Thu, Jan 4, 12:40 PM
adridg updated the diff for D13765: Fix audio/sayonara build on 10.3 i386.

No need for PORTREVISION bump, this is fixing build on i386
that didn't build before.

Thu, Jan 4, 12:39 PM
adridg created D13765: Fix audio/sayonara build on 10.3 i386.
Thu, Jan 4, 12:27 PM

Wed, Jan 3

adridg closed D13747: Update sayonara to 1.0.0.
Wed, Jan 3, 10:46 PM
adridg committed rP458004: Update audio/sayonara to latest upstream release 1.0.0.
Update audio/sayonara to latest upstream release 1.0.0
Wed, Jan 3, 10:46 PM
adridg created D13747: Update sayonara to 1.0.0.
Wed, Jan 3, 2:16 PM

Sat, Dec 30

adridg updated the diff for D13662: Help find Boost.

C++11 stuff has already been committed, so just leave the imported target fix

Sat, Dec 30, 10:53 PM
adridg committed rP457650: CMake 3.10 uses C++11, which needs to be explicitly enabled for.
CMake 3.10 uses C++11, which needs to be explicitly enabled for
Sat, Dec 30, 10:31 PM
adridg committed rP457644: Update www/otter-browser to latest released version..
Update www/otter-browser to latest released version.
Sat, Dec 30, 10:00 PM
adridg added a comment to D13634: New port: x11/polybar: Fast and easy-to-use status bar.

Some questions, but nothing serious. You can mark comments as "done" when they're done (e.g. the question about the WWW line) so as to indicate that things are progressing.

Sat, Dec 30, 4:25 PM
adridg added a comment to D8714: Make it possible to install py-qt5 for multiple python versions at the same time.

Isn't this largely obsoleted by flavors now? Or have flavors not reached the PyQt bits, and this stuff needs to be reworked to fit?

Sat, Dec 30, 2:53 PM
adridg accepted D13636: RFC: Add CMAKE_ON and CMAKE_OFF to cmake.mk.

I like it, since it pulls all of the boolean handling into something that looks consistent in the Makefile. It will need some PHB work, later, to give it some nice docs.

Sat, Dec 30, 2:36 PM
adridg accepted D13055: Set licenses for the PyQt ports.

While it is true that the license on PyQt is dual GPLv3 and Riverbank's license (RCL), the artifacts produced by the ports build system do not meet the requirements of the RCL (since they're tied to a single application, preferably statically linked). So even if you have an RCL, you can't use this -- so just stick to GPLv3.

Sat, Dec 30, 2:16 PM
adridg requested changes to D12979: The big KDE-thing (step0).

LGTM except for one breaking issue: the file kdegames4/Makefile.common was deleted, instead of moved to kdegames-kde4/, which looks like it breaks all of the individual game ports.

Sat, Dec 30, 1:46 PM
adridg added inline comments to D13662: Help find Boost.
Sat, Dec 30, 1:30 PM
adridg created D13694: CMake 3.10 needs C++11.
Sat, Dec 30, 1:23 PM

Fri, Dec 29

adridg requested changes to D13432: Updating py-khal to v0.9.8.

Please double-check upstream's comment about setup.cfg.

Fri, Dec 29, 2:35 PM · Python
adridg abandoned D13367: Update KDE Frameworks to 5.41.0.
Fri, Dec 29, 2:27 PM
adridg commandeered D13367: Update KDE Frameworks to 5.41.0.

Hostile takeover to get rid of it.

Fri, Dec 29, 2:27 PM
adridg updated the diff for D13662: Help find Boost.

While here, also add c++11-lang as requirement.

Fri, Dec 29, 1:44 PM

Thu, Dec 28

adridg created D13662: Help find Boost.
Thu, Dec 28, 2:34 PM

Sat, Dec 23

adridg committed rP457041: Update CMake to 3.10.1.
Update CMake to 3.10.1
Sat, Dec 23, 10:44 AM
adridg closed D13210: Update CMake to 3.10.1.
Sat, Dec 23, 10:44 AM

Wed, Dec 20

adridg created D13553: Unbreak unnethack.
Wed, Dec 20, 11:43 AM

Dec 18 2017

adridg accepted D13367: Update KDE Frameworks to 5.41.0.

LGTM, have it in use built from the kde5-import branch.

Dec 18 2017, 8:31 PM
adridg retitled D13210: Update CMake to 3.10.1 from Update CMake to 3.10.0 to Update CMake to 3.10.1.
Dec 18 2017, 9:02 AM
adridg updated the diff for D13210: Update CMake to 3.10.1.

Update to 3.10.1

Dec 18 2017, 8:59 AM
adridg abandoned D13439: Prepare openvsp for CMake 3.10.

Will do cmake update plus all these related fixes in one go in PR 223872

Dec 18 2017, 8:42 AM

Dec 11 2017

adridg created D13439: Prepare openvsp for CMake 3.10.
Dec 11 2017, 12:17 PM

Dec 1 2017

adridg committed rP455316: Fix patch comment..
Fix patch comment.
Dec 1 2017, 10:13 PM

Nov 25 2017

adridg committed rP454896: Update KDE ports that use OpenEXR, to use it optionally. This makes.
Update KDE ports that use OpenEXR, to use it optionally. This makes
Nov 25 2017, 8:43 PM
adridg closed D13132: Make OpenEXR optional for KDE ports..
Nov 25 2017, 8:43 PM
adridg updated the diff for D13132: Make OpenEXR optional for KDE ports..

OPTIONS_SUB -> yes (the value is ignored, but "yes" is traditional)

Nov 25 2017, 8:39 PM
adridg updated the diff for D13210: Update CMake to 3.10.1.

Fix misplaced subst of %%CMAKE_BUILD_TYPE%%

Nov 25 2017, 8:13 PM

Nov 23 2017

adridg updated the diff for D13210: Update CMake to 3.10.1.

Massage cmake-doc plist

Nov 23 2017, 10:20 AM
adridg created D13210: Update CMake to 3.10.1.
Nov 23 2017, 9:44 AM

Nov 20 2017

adridg added a comment to D11622: Port devel/qt4-dbus to arm64.

I'm trying to crochet a current Pine64 image (and failing). Building ports on NFS with the older Pine64 image is problematic, so this is kind of difficult to test. It *is* somewhere on our radar, though. But .. Qt4 is rather end-of-life, are you sure you want to put effort into fixing it now?

Nov 20 2017, 10:59 AM
adridg updated the diff for D13132: Make OpenEXR optional for KDE ports..
  • add OPTIONS to editors/calligra
  • add tabs where needed
Nov 20 2017, 10:50 AM
adridg added inline comments to D13132: Make OpenEXR optional for KDE ports..
Nov 20 2017, 10:26 AM

Nov 19 2017

adridg accepted D12508: Update graphics/krita to 3.3.0.

LGTM. Suggest we commit this, wait for fallout from use of gmic-qt, then bump to 3.3.1.

Nov 19 2017, 9:42 PM
adridg accepted D13107: comms/qt5-serialbus: Build the entire code instead of just src/serialbus.

tcberner@ points out some missing %%DEBUG%%, but otherwise looks ok. The CAN bus code probably useless, but there's nothing there that is weird or uncompilable.

Nov 19 2017, 9:41 PM
adridg abandoned D12966: Update KDE Frameworks to 5.40.0.

Have you tried turning it off again? This has already been committed.

Nov 19 2017, 4:48 PM
adridg commandeered D12966: Update KDE Frameworks to 5.40.0.

Hit it with a hammer until it does what I want.

Nov 19 2017, 4:47 PM

Nov 17 2017

adridg committed rP454392: Add latte-dock, an alternative launcher / taskbar from the KDE community..
Add latte-dock, an alternative launcher / taskbar from the KDE community.
Nov 17 2017, 11:11 PM
adridg closed D13075: Add port of latte-dock.
Nov 17 2017, 11:11 PM
adridg accepted D13050: Update graphics/gmic-qt to 215.

Has no consumers yet, graphics/krita (review D12508) will be the first.

Nov 17 2017, 8:02 PM
adridg created D13132: Make OpenEXR optional for KDE ports..
Nov 17 2017, 2:20 PM
adridg updated the diff for D12957: Switch to <opt>_CMAKE_BOOL.

Simplify ODBC options as well. You can combine _BOOL with _ON.

Nov 17 2017, 2:04 PM
adridg accepted D12966: Update KDE Frameworks to 5.40.0.

(trying to get this revision into a shape that tcberner can close it, since it was already committed)

Nov 17 2017, 1:32 PM
adridg added inline comments to D10168: Update www/chokoq to 1.6.0.
Nov 17 2017, 12:41 PM
adridg updated the diff for D13075: Add port of latte-dock.

Pet the human portlint. Update WWW to point to KDE.

Nov 17 2017, 11:34 AM

Nov 16 2017

adridg added a member for kde: adridg.
Nov 16 2017, 12:57 PM
adridg added inline comments to D13075: Add port of latte-dock.
Nov 16 2017, 10:39 AM
adridg updated the diff for D13075: Add port of latte-dock.

Massage pkg-plist

Nov 16 2017, 10:30 AM
adridg committed rP454301: Update the cmake family to 3.9.6 (skip 3.9.5, the upstream.
Update the cmake family to 3.9.6 (skip 3.9.5, the upstream
Nov 16 2017, 10:15 AM
adridg closed D12958: Update CMake to 3.9.6.
Nov 16 2017, 10:15 AM

Nov 14 2017

adridg updated the diff for D13075: Add port of latte-dock.

Line breaks, polish LICENSE data.

Nov 14 2017, 11:42 AM

Nov 13 2017

adridg created D13075: Add port of latte-dock.
Nov 13 2017, 11:23 PM

Nov 12 2017

adridg committed rP454088: Update irc/konversation to latest upstream release..
Update irc/konversation to latest upstream release.
Nov 12 2017, 9:57 PM
adridg closed D13065: Update irc/konversation to 1.7.3.
Nov 12 2017, 9:57 PM
adridg committed rP454087: security/vuxml: Document vulnerability in irc/konversation.
security/vuxml: Document vulnerability in irc/konversation
Nov 12 2017, 9:55 PM
adridg updated the diff for D13065: Update irc/konversation to 1.7.3.

Add secondary url

Nov 12 2017, 9:47 PM
adridg updated the diff for D13065: Update irc/konversation to 1.7.3.

Fix package name, add CVE url.

Nov 12 2017, 9:34 PM
adridg updated the diff for D13065: Update irc/konversation to 1.7.3.

Use <cvename> instead of <url>

Nov 12 2017, 9:19 PM
adridg created D13065: Update irc/konversation to 1.7.3.
Nov 12 2017, 9:16 PM
adridg added a reviewer for D12957: Switch to <opt>_CMAKE_BOOL: jlaffaye.

MAINTAINER should be a reviewer, not just subscribed.

Nov 12 2017, 3:10 PM
adridg updated the diff for D12957: Switch to <opt>_CMAKE_BOOL.

Minor updates

Nov 12 2017, 3:09 PM
adridg reclaimed D12957: Switch to <opt>_CMAKE_BOOL.
Nov 12 2017, 3:08 PM
adridg abandoned D12957: Switch to <opt>_CMAKE_BOOL.
Nov 12 2017, 3:05 PM

Nov 11 2017

adridg retitled D12958: Update CMake to 3.9.6 from Update CMake to 3.9.5 to Update CMake to 3.9.6.
Nov 11 2017, 3:16 PM
adridg updated the diff for D12958: Update CMake to 3.9.6.
  • update distinfo
  • sort variables according to chapter 14
Nov 11 2017, 3:14 PM
adridg updated the diff for D12958: Update CMake to 3.9.6.

Update to 3.9.6 .. the upstream CMake releases are coming
thick and fast. This release reverts an easier change to
gcc_eh linking.

Nov 11 2017, 3:07 PM

Nov 5 2017

adridg added a comment to D12964: New port, www/py-qt5-webengine: Python bindings for the Qt5 toolkit,QtWebEngine module.

As @tcberner says, it's probably best to try to split this into two, webchannel and webengine, to match the existing lightweight(-ish) qt5-webchannel and the heavyweight qt5-webengine.

Nov 5 2017, 9:57 PM

Nov 4 2017

adridg created D12958: Update CMake to 3.9.6.
Nov 4 2017, 10:18 PM
adridg created D12957: Switch to <opt>_CMAKE_BOOL.
Nov 4 2017, 9:50 PM
adridg committed rP453489: Bump PORTREVISION, which I should have done in r453379 when I changed.
Bump PORTREVISION, which I should have done in r453379 when I changed
Nov 4 2017, 9:42 PM
adridg closed D12941: Bump PORTREVISION..
Nov 4 2017, 9:42 PM
adridg created D12941: Bump PORTREVISION..
Nov 4 2017, 2:57 PM