Page MenuHomeFreeBSD

Allow USES=kde without specifying the version
AcceptedPublic

Authored by makc on Jul 31 2026, 4:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 31, 1:15 PM
Unknown Object (File)
Mon, Aug 31, 11:57 AM
Unknown Object (File)
Mon, Aug 31, 1:52 AM
Unknown Object (File)
Sun, Aug 30, 10:07 AM
Unknown Object (File)
Thu, Aug 27, 9:55 AM
Unknown Object (File)
Wed, Aug 26, 3:19 PM
Unknown Object (File)
Fri, Aug 21, 10:14 PM
Unknown Object (File)
Fri, Aug 21, 8:51 PM

Details

Reviewers
arrowd
jhale
Group Reviewers
kde
Summary

A bunch of ports use only extra cmake modules (ECM), so they do no care about Frameworks version at all. Besides, we have dropped KF5 ECM in favour of KF6 counterpart when we switched to Plasma 6 ports, so both USES=kde:[56] pull the latest ECM.

This patch allows ports to enlist USES=kde without specifying the version.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

makc requested review of this revision.Jul 31 2026, 4:05 PM
makc created this revision.
This revision is now accepted and ready to land.Aug 1 2026, 2:24 PM

With all due respect, I think this is a bad idea. When KF7 rolls around years later and folks have made ports with versionless USES=kde, I can see this becoming a headache. If we are going to support versionless USES=kde, it should only be for specific components like ECM.

Mk/Uses/kde.mk
1055

With the removal of the . else/. endif, all of the indents need to be demoted by 2 spaces.

jhale requested changes to this revision.Aug 2 2026, 5:21 AM
jhale added a reviewer: jhale.
This revision now requires changes to proceed.Aug 2 2026, 5:21 AM

Actually, Jason made a good point. How about adding a .warning for cases when USES=kde is versionless and USE_KDE contains anything but ecm?

Introduce _USE_KDE_LATEST for components which can be used without requesting KDE Frameworks version.
Convert audio/zrythm to USES=kde.
Drop runtime dependency on ecm for affected ports.

With all due respect, I think this is a bad idea. When KF7 rolls around years later and folks have made ports with versionless USES=kde, I can see this becoming a headache. If we are going to support versionless USES=kde, it should only be for specific components like ECM.

Agree.

Mk/Uses/kde.mk
1055

I was going to fix this in a separate commit.

jhale requested changes to this revision.Tue, Aug 4, 3:17 AM

Otherwise, LGTM.

Mk/Uses/kde.mk
79

Small typo: s/specifed/specified

This revision now requires changes to proceed.Tue, Aug 4, 3:17 AM

Fix spelling and amend indentation.

makc marked 2 inline comments as done.Tue, Aug 4, 12:50 PM
adridg added inline comments.
Mk/Uses/kde.mk
8

"may be omitted when"

Mk/Uses/kde.mk
8

That line sounded weird to me as native English speaker, but I couldn't quite ex[plain why. That is way better wording.

makc marked 2 inline comments as done.
This revision is now accepted and ready to land.Tue, Aug 11, 8:12 PM