tools/build: Support building with glibc 2.38
ClosedPublic
Actions

Authored by andrew on Oct 19 2023, 4:55 PM.

Details

Reviewers

jrtc27
arichardson
brooks

Commits

rG55e2bfab4485: tools/build: Support building with glibc 2.38
rGceefd491c7f0: tools/build: Support building with glibc 2.38

Summary

Ubuntu 23.10 uses glibc 2.38. This adds strlcpy and strlcmp so we need
to remove them from the cross build environment.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Oct 19 2023, 4:55 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 19 2023, 4:55 PM

andrew requested review of this revision.Oct 19 2023, 4:55 PM

Harbormaster completed remote builds in B54092: Diff 129114.Oct 19 2023, 4:55 PM

This looks sensible, but please file a dummy PR against https://github.com/freebsd/freebsd-src in order to run it through the various GitHub Actions runners to test other versions of Ubuntu (and macOS, but shouldn't be relevant) before merging.

This revision is now accepted and ready to land.Oct 19 2023, 4:57 PM

andrew retitled this revision from tools/build: Support building with glibc 2.28 to tools/build: Support building with glibc 2.38.Oct 20 2023, 10:43 AM

andrew edited the summary of this revision. (Show Details)

Should be 2.38

This revision now requires review to proceed.Oct 20 2023, 10:44 AM

Harbormaster completed remote builds in B54108: Diff 129148.Oct 20 2023, 10:44 AM

I enabled the action on an (incorrectly named) branch: https://github.com/zxombie/freebsd/actions/runs/6586564251.

arichardson accepted this revision.Oct 20 2023, 1:53 PM

This revision is now accepted and ready to land.Oct 20 2023, 1:53 PM

imp added inline comments.Oct 20 2023, 2:36 PM

tools/build/Makefile
204	This seems super fragile, though a nice one liner. A more direct test would be to run `#include <string.h>` through the compiler's pre-processor and grep for strlcpy.