uchcom: Try to fix upload to esp8266
Needs ReviewPublic
Actions

Authored by probono_puredarwin.org on Apr 23 2023, 11:30 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Oct 10, 10:16 AM

	Unknown Object (File)
	Sat, Oct 10, 10:05 AM

	Unknown Object (File)
	Fri, Oct 9, 5:43 PM

	Unknown Object (File)
	Fri, Oct 9, 5:04 PM

	Unknown Object (File)
	Sun, Oct 4, 8:03 AM

	Unknown Object (File)
	Thu, Oct 1, 2:38 PM

	Unknown Object (File)
	Tue, Sep 29, 2:18 PM

	Unknown Object (File)
	Sat, Sep 26, 6:25 PM

View All Files

Subscribers

imp

This revision needs review, but all specified reviewers are disabled or inactive.

Details

Reviewers

• hselasky

Summary

Currently uploading to esp8266 usinf uchcom devices fails.
It was suggested to port some logic from umodem.

https://github.com/helloSystem/ISO/issues/479
https://github.com/espressif/esptool/issues/272

Test Plan

If this works, then uploading to esp8266 using esptool should no longer fail.
I was not able to compile and test this yet.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

probono_puredarwin.org created this revision.Apr 23 2023, 11:30 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 23 2023, 11:30 AM

probono_puredarwin.org requested review of this revision.Apr 23 2023, 11:30 AM

Just use the existing USB transfers:
UCHCOM_BULK_WR -> UCHCOM_BULK_DT_WR
UCHCOM_BULK_RD -> UCHCOM_BULK_DT_RD

Upload patch with full context: -U999999

Ping.

Sorry @hselasky I don't know how to do either.
If only we could use GitHub Pull Requests.

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

serial/

uchcom.c

36 lines

Diff 120894

View Options

sys/dev/usb/serial/uchcom.c

uchcom: Try to fix upload to esp8266Needs ReviewPublicActions