Differential D38931

byacc: Disable backtracking extension.
ClosedPublic
Actions

Authored by des on Mar 6 2023, 6:11 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Jan 12 2024, 4:28 AM

	Unknown Object (File)
	Dec 20 2023, 7:43 AM

	Unknown Object (File)
	Oct 11 2023, 9:18 AM

	Unknown Object (File)
	Oct 11 2023, 9:18 AM

	Unknown Object (File)
	Aug 24 2023, 2:59 PM

	Unknown Object (File)
	Jul 9 2023, 4:35 PM

	Unknown Object (File)
	Jul 9 2023, 4:33 PM

	Unknown Object (File)
	Jul 9 2023, 4:30 PM

View All 19 Files

Subscribers

Details

Reviewers

jkim
imp

Group Reviewers

Commits

rG473a2c9a40e8: byacc: Disable backtracking extension.

Summary

When updating byacc to 20230201, I enabled the backtracking extension as it seemed useful and harmless. With a little more experience, it appears to have more impact than I initially thought and I'm no longer sure how useful it really is, so turn it back off.

PR: 244149, 269425
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Mar 6 2023, 6:11 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 6 2023, 6:11 PM

des requested review of this revision.Mar 6 2023, 6:11 PM

Harbormaster completed remote builds in B50171: Diff 118408.Mar 6 2023, 6:11 PM

des edited the summary of this revision. (Show Details)Mar 6 2023, 6:13 PM

LGTM

This revision is now accepted and ready to land.Mar 6 2023, 7:06 PM

I believe that dtc uses (or used) it?
But not in base, and the port already does the right workarounds.

Closed by commit rG473a2c9a40e8: byacc: Disable backtracking extension. (authored by des). · Explain WhyMar 7 2023, 5:22 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG473a2c9a40e8: byacc: Disable backtracking extension..

Revision Contents
Changeset List

Path

Size

usr.bin/

yacc/

2 lines

Diff 118465

usr.bin/yacc/config.h

Loading...