Page MenuHomeFreeBSD

emulators/virtualbox-ose-kmod: Fix build with LLVM 15
ClosedPublic

Authored by jrm on Mar 4 2023, 2:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 13, 2:26 PM
Unknown Object (File)
Sun, Mar 10, 9:13 AM
Unknown Object (File)
Sun, Mar 10, 9:13 AM
Unknown Object (File)
Sun, Mar 10, 9:08 AM
Unknown Object (File)
Jan 18 2024, 1:18 PM
Unknown Object (File)
Jan 5 2024, 5:45 PM
Unknown Object (File)
Dec 23 2023, 1:33 AM
Unknown Object (File)
Dec 13 2023, 2:22 AM
Subscribers

Details

Summary

When LLVM 15 was imported in 14-CURRENT, the build failed because
starting with clang 15, the -Wint-conversion warning diagnostic for
implicit int <-> pointer conversions defaults to an error. Use a cast to
fix the error.

See also: https://lists.freebsd.org/archives/freebsd-emulation/2023-February/000431.html

https://lists.freebsd.org/archives/freebsd-emulation/2023-February/000460.html

PR: 269721
Reported by: fbl@aoek.com, ohartmann@walstatt.org, rkoberman@gmail.com

Test Plan

poudriere build tested on 12/13/14

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jrm requested review of this revision.Mar 4 2023, 2:08 PM
lwhsu added a subscriber: lwhsu.

I'm not really on vbox@ but I think this fix is suitable for blanket approval.

This revision is now accepted and ready to land.Mar 6 2023, 8:55 AM

FYI, the fix was incomplete. I fixed remaining ones in 7270b8992214.

In D38906#886506, @jkim wrote:

FYI, the fix was incomplete. I fixed remaining ones in 7270b8992214.

Sorry. I didn't see those errors when testing and poudriere testport built fine for me.

http://pkg.ftfl.ca/data/14amd64-default/2023-03-06_16h57m27s/logs/virtualbox-ose-kmod-6.1.36.log