Page MenuHomeFreeBSD
Differential D41563

sff: Improve names and error messages
AcceptedPublic
Actions

Authored by dsl on Aug 23 2023, 12:28 PM.
Tags
None
Referenced Files
F171085564: D41563.id126534.diff
Tue, Sep 8, 2:58 PM
F171058076: D41563.id127178.diff
Tue, Sep 8, 11:08 AM
F171058022: D41563.id126414.diff
Tue, Sep 8, 11:08 AM
F170968960: D41563.diff
Mon, Sep 7, 10:24 PM
Unknown Object (File)
Sun, Sep 6, 12:17 AM
Unknown Object (File)
Sat, Sep 5, 5:37 PM
Unknown Object (File)
Sat, Sep 5, 5:32 PM
Unknown Object (File)
Sat, Sep 5, 11:30 AM
View All Files
Subscribers
imp
loos
arm64

Details

Reviewers
jrtc27
bz
Summary

Names of the GPIO handles and printed errors are improved for readability.

Test Plan

N/A

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dsl created this revision.Aug 23 2023, 12:28 PM
Herald added subscribers: loos, imp. · View Herald TranscriptAug 23 2023, 12:28 PM
dsl requested review of this revision.Aug 23 2023, 12:28 PM
bz added a subscriber: arm64.Aug 23 2023, 10:09 PM
dsl added a comment.Aug 24 2023, 7:59 AM

@jrtc27 Could you comment or accept it if everything's according to your expectation?

dsl updated this revision to Diff 126534.Aug 25 2023, 10:28 PM

Added a comment about "mod_abs"

bz added a comment.Sep 5 2023, 6:52 PM

@jrtc27 given this seems to be partially triggered by feedback from you, any further comments?

jrtc27 added a comment.Sep 5 2023, 6:56 PM

One comment otherwise LGTM

sys/dev/sff/sfp_fdt.c
119–120
dsl updated this revision to Diff 127178.Sep 9 2023, 2:13 PM
dsl marked an inline comment as done.

re-based and updated according to the comment

dsl added a comment.Sep 19 2023, 10:39 AM

@jrtc27 @bz Any comments?

bz accepted this revision.Sep 21 2023, 5:02 PM

Approved by: bz (mentor)

This revision is now accepted and ready to land.Sep 21 2023, 5:02 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sff/
53 lines

Diff 127178

View Options

sys/dev/sff/sfp_fdt.c

Loading...