Page MenuHomeFreeBSD
Differential D49044

net/samba4{19,20}: "samba-tool domain backup offline" hangs
ClosedPublic
Actions

Authored by michaelo on Feb 18 2025, 8:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 12, 7:52 PM
Unknown Object (File)
Sun, Oct 12, 4:56 PM
Unknown Object (File)
Wed, Oct 1, 6:59 AM
Unknown Object (File)
Tue, Sep 30, 8:44 PM
Unknown Object (File)
Fri, Sep 26, 9:26 AM
Unknown Object (File)
Sat, Sep 20, 2:05 PM
Unknown Object (File)
Sep 12 2025, 8:32 PM
Unknown Object (File)
Sep 10 2025, 2:23 PM
View All 51 Files
Subscribers
allanjude

Details

Reviewers
kiwi
vvd
timur
yasu
jrm
otis
0mp
kevans
allanjude
Commits
R11:cbfef6eec11b: net/samba419: "samba-tool domain backup offline" hangs
R11:1db23ed5ef53: net/samba4{19,20}: "samba-tool domain backup offline" hangs
Summary

PR: 250906
Tested by: ml@netfence.it
Approved by: jrm (mentor), otis (mentor)
MFH: 2025Q1

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michaelo requested review of this revision.Feb 18 2025, 8:51 AM
michaelo created this revision.
Harbormaster completed remote builds in B62496: Diff 151136.Feb 18 2025, 8:51 AM
kiwi added reviewers: 0mp, kevans.Feb 18 2025, 8:57 AM
allanjude accepted this revision.Feb 18 2025, 2:21 PM
allanjude added a subscriber: allanjude.

silly GNU getopt

This revision is now accepted and ready to land.Feb 18 2025, 2:21 PM
otis accepted this revision.Feb 18 2025, 2:29 PM

Seal of approval.

kiwi added a comment.Feb 18 2025, 2:49 PM
In D49044#1118258, @allanjude wrote:

silly GNU getopt

Maybe we should push this patch into Samba repo as well?

kiwi accepted this revision.Feb 18 2025, 2:49 PM
vvd accepted this revision.Feb 18 2025, 3:37 PM
michaelo added a comment.Feb 18 2025, 4:41 PM
In D49044#1118284, @kiwi wrote:
In D49044#1118258, @allanjude wrote:

silly GNU getopt

Maybe we should push this patch into Samba repo as well?

Well, GNU getopt isn't POSIX-compliant by default: https://bugzilla.samba.org/show_bug.cgi?id=15804#c1

Ideally this would be upstream, see https://lists.samba.org/archive/samba-technical/2024-August/139090.html, but John isn't responding to my emails.

Closed by commit R11:1db23ed5ef53: net/samba4{19,20}: "samba-tool domain backup offline" hangs (authored by ml_netfence.it, committed by michaelo). · Explain WhyFeb 18 2025, 4:49 PM
This revision was automatically updated to reflect the committed changes.
michaelo added a commit: R11:1db23ed5ef53: net/samba4{19,20}: "samba-tool domain backup offline" hangs.
michaelo added a commit: R11:cbfef6eec11b: net/samba419: "samba-tool domain backup offline" hangs.Feb 18 2025, 4:54 PM

Revision Contents
Changeset List

PathSize
net/
samba419/
2 lines
files/
15 lines
samba420/
2 lines
files/
15 lines

Diff 151147

View Options

net/samba419/Makefile

Loading...
View Options

net/samba419/files/patch-python_samba_tdb__util.py

Loading...
View Options

net/samba420/Makefile

Loading...
View Options

net/samba420/files/patch-python_samba_tdb__util.py

Loading...