User Details
- User Since
- Feb 13 2018, 3:16 PM (52 w, 3 d)
Today
Thu, Feb 14
Wed, Feb 13
LGTM
Tue, Feb 12
Sat, Feb 9
Thu, Jan 31
Jan 14 2019
LGTM
Dec 11 2018
Dec 10 2018
Nov 28 2018
Nov 27 2018
Nov 18 2018
Nov 17 2018
I've committed somewhat joint result of the given patches and https://reviews.freebsd.org/D16878.
Nov 13 2018
LGTM
Nov 8 2018
Nov 6 2018
Also, an entry to the MOVED file should be added. Maybe along with the entry in UPDATING.
Oct 23 2018
Kevin, can you make change requested by mat? As I understand, NO_ARCH should go after USE* block.
Oct 18 2018
I also don't see any issue now, but as it's not the first time ordering question arise - do you run portlint when preparing (new) ports? If so, can you, please, also provide it's output?
Oct 8 2018
LGTM
Sep 29 2018
Not really your bug, but while you are there - there should be TAB on the indicated place.
Also, forgive my laziness, but seeing the result of make validate would let me not to check this entry on my system :)
In general, we are trying not to be too verbose in the description section, at least that's what I see for the other entries in vuln.xml. I believe it's enough to have the first paragraph with the short vulnerability description and not necessary to dive into the details how maintainers reacted on the CVE. That's what the URL is for, if anyone needs more details.
Sep 20 2018
Sep 6 2018
That's not working OOTB.
Sep 4 2018
Approved for gcc7* changes
Sep 2 2018
Aug 31 2018
Aug 14 2018
Aug 6 2018
Jul 31 2018
Jul 3 2018
Jun 8 2018
May 17 2018
Apr 12 2018
Mar 25 2018
Mar 24 2018
Mar 14 2018
Mar 13 2018
Mar 5 2018
Feb 28 2018
Feb 20 2018
Feb 13 2018
databases/ldb/files/patch-buildtoolswafsambasamba_autoconf.py
This file was deleted.
Out of curiosity I've checked the build of ldb 1.3.1 without the patch-buildtools__wafsamba__samba_autoconf.py. Obvi
This is pretty big changeset, can you give a summary, how this differs from the samba47/ besides bumping related ports versions?
I appreciate your effort and can understand your impatience to get desired functionality, but this is (almost) all plainly wrong. You deleting patches without evaluating what are they meant for, you alter ldb/ port so it gets incompatible with with samba46/ and samba47/, while there is ldb13/ exactly for this purpose, you introduce usage of GitHub, while the dist files are already on download.samba.org...