bsdinstall: Report error from installing firmware

[emaste]

Summary

Event:          Kitchener-Waterloo Hackathon 202506
Sponsored by:   The FreeBSD Foundation

[emaste]

usr.sbin/bsdinstall/scripts/firmware

131

Open to suggestions of better ways to handle this, but hopefully this is at least a small step forward

[emaste]

Correct test

[ziaee]

usr.sbin/bsdinstall/scripts/firmware

131

Isn't there a "press enter to continue" command? 5 is a lot when you've had enough coffee/seen it before.

[emaste]

fix failure test if more than one fw file is in the fail list

[emaste]

usr.sbin/bsdinstall/scripts/firmware

131

The bsddialog below is a "press enter to continue." The problem is that the error will already have disappeared due to screen clearing.

This delay/message does not occur during regular operation so I don't think it is too much of an issue.

The alternative would be just something like

echo "Error fetching ...; press Enter"
read dummy

but our installer is already uglified by having random console spam and I'd rather not perpetuate that

[ziaee]

I see, thanks @emaste!

[allanjude]

I wonder if the -q ends up hiding too much useful context for the error, but better to avoid the console spam in the happy case.