Differential D48181

diff: Fix device case.
ClosedPublic
Actions

Authored by des on Dec 23 2024, 5:09 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jan 19, 9:35 PM

	Unknown Object (File)
	Tue, Dec 31, 5:49 PM

	Unknown Object (File)
	Dec 26 2024, 5:16 AM

	Unknown Object (File)
	Dec 26 2024, 2:00 AM

	Unknown Object (File)
	Dec 26 2024, 1:49 AM

	Unknown Object (File)
	Dec 25 2024, 9:46 PM

	Unknown Object (File)
	Dec 23 2024, 5:18 PM

Subscribers

Details

Reviewers

thj
mav
allanjude

Commits

rG893839b11988: diff: Fix device case.

Summary

We already fell back to Stone for FIFOs, but we actually need to fall
back to Stone for everything except regular files, because libdiff's
atomizer needs to know the size of its input in advance, and neither
FIFOs nor devices can be trusted to report their size.

MFC after: 1 week
Reported by: mav

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Dec 23 2024, 5:09 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 23 2024, 5:09 PM

des requested review of this revision.Dec 23 2024, 5:09 PM

Harbormaster completed remote builds in B61309: Diff 148349.Dec 23 2024, 5:09 PM

Reviewed by: allanjude

This revision is now accepted and ready to land.Dec 23 2024, 5:11 PM

mav accepted this revision.Dec 23 2024, 5:12 PM

Closed by commit rG893839b11988: diff: Fix device case. (authored by des). · Explain WhyDec 23 2024, 5:16 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG893839b11988: diff: Fix device case..

Revision Contents
Changeset List

Path

Size

usr.bin/

diff/

4 lines

Diff 148350

usr.bin/diff/diffreg_new.c

Loading...