Page MenuHomeFreeBSD

bsdinstall: Only offer to enable services which are installed
ClosedPublic

Authored by ivy on Sat, Sep 20, 9:11 PM.
Tags
None
Referenced Files
F132109872: D52646.diff
Mon, Oct 13, 7:25 PM
Unknown Object (File)
Sat, Oct 11, 11:14 PM
Unknown Object (File)
Sat, Oct 11, 11:14 PM
Unknown Object (File)
Sat, Oct 11, 11:14 PM
Unknown Object (File)
Sat, Oct 11, 1:56 PM
Unknown Object (File)
Thu, Oct 9, 7:25 PM
Unknown Object (File)
Thu, Oct 9, 5:27 PM
Unknown Object (File)
Tue, Oct 7, 3:58 AM

Details

Summary

With pkgbase, users may decide to install a minimal set of packages
that's missing some daemons. Check which services are installed, and
only include the ones which are present in the dialogue.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivy requested review of this revision.Sat, Sep 20, 9:11 PM

Would it maybe make more sense to keep the list, but install the services they enabled but have not installed?

Would it maybe make more sense to keep the list, but install the services they enabled but have not installed?

i'm planning to add some of these services to the pkgbase component selection dialogue. they don't really belong in any of the package sets we currently offer, but a lot of people want these running (which is why they're here to begin with) so it's reasonable to add explicit entries for them.

since the pkgbase dialogue runs before this dialogue, they'll already be installed by the time we get here and the option to start them will show up.

In D52646#1204221, @ivy wrote:

i'm planning to add some of these services to the pkgbase component selection dialogue.

to expand on that a bit: powerd and moused are in set-minimal, so they will always be installed on non-jail systems. neither will be installed in jails by default, in which case it's fine if we don't show them here either (who wants powerd in a jail?).

ssh and ntpd are common enough that i'll add an explicit option for them in the pkgbase step. although we could instead modify this dialogue to offer to install them in the pkgbase case, it's possible to build the system without either of them, meaning there are no packages for them, so we'd have to duplicate the logic from the pkgbase step to determine which packages are available. i think it's easier to handle that in the existing pkgbase step.

for local_unbound, i don't really understand the use-case for it, so i'll need to consider how we handle that.

cperciva added a subscriber: cperciva.
cperciva added inline comments.
usr.sbin/bsdinstall/scripts/services
80

I could consider moving this up to line 73 with a # this is always an option, just for the sake of consistency

This revision is now accepted and ready to land.Tue, Sep 30, 5:42 AM