libbe: avoid copying encryption-related props

[kevans]

Summary

libzfs insists that these be cloned from the origin, so avoid making a
deep copy of them ourselves to unbreak creating a new BE from an
encrypted BE.

[arrowd]

I can confirm this fixed the problem for me.

[arrowd]

Can we get this in?

[arrowd]

Another bump. This is a useful change that we're using at $WORK for quite a time.

[allanjude]

Otherwise looks good to me.

I am interesting in your use case, how are you using encrypted datasets as part of a boot environment without support in the boot loader? Or is it only for children of the root filesystem (nested under the BE)?

lib/libbe/be.c

692

We should have a fallthrough annotation here I think, to make it obvious it is going to go down to the return (ZPROP_CONT); under CANMOUNT

[arrowd]

Or is it only for children of the root filesystem (nested under the BE)?

Yes, it is a child of a user's home dataset, which is encrypted.

[kevans]

In D48464#1120848, @arrowd wrote:

Or is it only for children of the root filesystem (nested under the BE)?

Yes, it is a child of a user's home dataset, which is encrypted.

I fixed the commit message to more clearly depict the affected setup.

[arrowd]

Thanks for fixing this for me!