Page MenuHomeFreeBSD

libbe: avoid copying encryption-related props
ClosedPublic

Authored by kevans on Jan 15 2025, 3:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 9, 9:32 PM
Unknown Object (File)
Fri, Oct 3, 4:20 PM
Unknown Object (File)
Fri, Oct 3, 10:41 AM
Unknown Object (File)
Sat, Sep 27, 3:14 AM
Unknown Object (File)
Fri, Sep 19, 12:37 PM
Unknown Object (File)
Sep 14 2025, 1:35 AM
Unknown Object (File)
Sep 13 2025, 12:44 PM
Unknown Object (File)
Sep 13 2025, 7:01 AM
Subscribers

Details

Summary

libzfs insists that these be cloned from the origin, so avoid making a
deep copy of them ourselves to unbreak creating a new BE from an
encrypted BE.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I can confirm this fixed the problem for me.

Another bump. This is a useful change that we're using at $WORK for quite a time.

Otherwise looks good to me.

I am interesting in your use case, how are you using encrypted datasets as part of a boot environment without support in the boot loader? Or is it only for children of the root filesystem (nested under the BE)?

lib/libbe/be.c
692

We should have a fallthrough annotation here I think, to make it obvious it is going to go down to the return (ZPROP_CONT); under CANMOUNT

This revision is now accepted and ready to land.Feb 26 2025, 4:55 PM

Or is it only for children of the root filesystem (nested under the BE)?

Yes, it is a child of a user's home dataset, which is encrypted.

Or is it only for children of the root filesystem (nested under the BE)?

Yes, it is a child of a user's home dataset, which is encrypted.

I fixed the commit message to more clearly depict the affected setup.

Thanks for fixing this for me!