cp: Address style issues from external review.
ClosedPublic
Actions

Authored by des on May 8 2025, 6:03 PM.

Tags

None

Referenced Files

	F141979896: D50256.id155239.diff
	Wed, Jan 14, 11:35 AM

	Unknown Object (File)
	Sat, Jan 10, 9:52 PM

	Unknown Object (File)
	Thu, Jan 8, 5:59 AM

	Unknown Object (File)
	Wed, Jan 7, 5:33 AM

	Unknown Object (File)
	Sun, Dec 28, 7:48 PM

	Unknown Object (File)
	Fri, Dec 26, 2:06 AM

	Unknown Object (File)
	Sat, Dec 20, 1:54 AM

	Unknown Object (File)
	Nov 14 2025, 12:57 AM

View All 56 Files

Subscribers

imp

Details

Reviewers

markj
allanjude

Group Reviewers

Klara

Commits

rGa4f6317bb64b: cp: Address style issues from external review.

Summary

Correctly indent some comment blocks.
Avoid using strcpy(), even when we know it's safe.
Drop the (void) casts from fts_set() calls which can never fail.

Fixes: 82fc0d09e862
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.May 8 2025, 6:03 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 8 2025, 6:03 PM

des requested review of this revision.May 8 2025, 6:03 PM

Harbormaster completed remote builds in B64009: Diff 155149.May 8 2025, 6:03 PM

des added a child revision: D50257: cp: Fix dead link case..May 8 2025, 6:03 PM

markj accepted this revision as: markj.May 8 2025, 11:28 PM

This revision is now accepted and ready to land.May 8 2025, 11:28 PM

allanjude accepted this revision.May 9 2025, 12:51 PM

Closed by commit rGa4f6317bb64b: cp: Address style issues from external review. (authored by des). · Explain WhyMay 10 2025, 8:58 AM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGa4f6317bb64b: cp: Address style issues from external review..

Revision Contents
Changeset List

Path

Size

bin/

cp/

cp.c

54 lines

Diff 155239

View Options

cp: Address style issues from external review.ClosedPublicActions