route: avoid overlapping strcpy
AcceptedPublic
Actions

Authored by kevans on Oct 23 2021, 6:55 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mar 19 2024, 7:19 PM

	Unknown Object (File)
	Mar 7 2024, 3:51 AM

	Unknown Object (File)
	Feb 18 2024, 12:31 AM

	Unknown Object (File)
	Jan 16 2024, 2:12 AM

	Unknown Object (File)
	Dec 25 2023, 5:41 PM

	Unknown Object (File)
	Dec 5 2023, 8:00 PM

	Unknown Object (File)
	Nov 25 2023, 1:46 PM

	Unknown Object (File)
	Nov 18 2023, 7:31 AM

View All 20 Files

Subscribers

imp

Details

Reviewers

melifaro
thj
imp

Summary

Passing overlapping buffers to strcpy yields an undefined result, so
let's avoid it. The copy doesn't really need to happen anyways.

This was discovered with _FORTIFY_SOURCE.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 42322
Build 39210: arc lint + arc unit

Event Timeline

kevans created this revision.Oct 23 2021, 6:55 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 23 2021, 6:55 PM

kevans requested review of this revision.Oct 23 2021, 6:55 PM

Harbormaster completed remote builds in B42322: Diff 97338.Oct 23 2021, 6:55 PM

This should be marginally faster too...

This revision is now accepted and ready to land.Oct 23 2021, 7:10 PM

melifaro accepted this revision.Oct 23 2021, 7:35 PM

Revision Contents
Changeset List

Path

Size

sbin/

route/

route.c

20 lines

Diff 97338

View Options

route: avoid overlapping strcpyAcceptedPublicActions