Page MenuHomeFreeBSD

strptime: Fix day-of-week calculation.
ClosedPublic

Authored by des on Dec 7 2024, 1:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 3:07 AM
Unknown Object (File)
Sun, Oct 12, 7:36 PM
Unknown Object (File)
Fri, Oct 10, 5:17 AM
Unknown Object (File)
Wed, Oct 8, 8:40 PM
Unknown Object (File)
Fri, Oct 3, 1:33 AM
Unknown Object (File)
Sun, Sep 21, 9:01 AM
Unknown Object (File)
Sep 12 2025, 4:29 PM
Unknown Object (File)
Sep 12 2025, 10:26 AM
Subscribers

Details

Summary

The day-of-week calculation used the raw year value without adjusting
for TM_YEAR_BASE, so it was off by one for 300 years out of every 400;
it just happened to be correct for 1901 through 2000. It also used a
loop where a simple addition would have sufficed.

While here, simplify our version of Gauss's algorithm, and document
that we assume the Gregorian calendar.

MFC after: 1 week
PR: 282916

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Dec 7 2024, 1:35 PM
This revision is now accepted and ready to land.Dec 7 2024, 1:59 PM

Looks good! Thank you for the test case. :-)

This revision was automatically updated to reflect the committed changes.