Page MenuHomeFreeBSD

strptime: Fix day-of-week calculation.
ClosedPublic

Authored by des on Dec 7 2024, 1:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 22, 12:58 AM
Unknown Object (File)
Thu, Jun 4, 10:08 PM
Unknown Object (File)
Thu, Jun 4, 11:49 AM
Unknown Object (File)
May 21 2026, 8:55 PM
Unknown Object (File)
May 17 2026, 12:32 AM
Unknown Object (File)
May 16 2026, 4:15 PM
Unknown Object (File)
May 15 2026, 10:25 PM
Unknown Object (File)
May 14 2026, 12:42 PM
Subscribers

Details

Summary

The day-of-week calculation used the raw year value without adjusting
for TM_YEAR_BASE, so it was off by one for 300 years out of every 400;
it just happened to be correct for 1901 through 2000. It also used a
loop where a simple addition would have sufficed.

While here, simplify our version of Gauss's algorithm, and document
that we assume the Gregorian calendar.

MFC after: 1 week
PR: 282916

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Dec 7 2024, 1:35 PM
This revision is now accepted and ready to land.Dec 7 2024, 1:59 PM

Looks good! Thank you for the test case. :-)

This revision was automatically updated to reflect the committed changes.