Page MenuHomeFreeBSD

strptime: Fix day-of-week calculation.
ClosedPublic

Authored by des on Dec 7 2024, 1:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 9, 3:54 PM
Unknown Object (File)
Fri, Dec 5, 5:06 AM
Unknown Object (File)
Tue, Nov 25, 10:58 PM
Unknown Object (File)
Nov 16 2025, 3:34 PM
Unknown Object (File)
Nov 13 2025, 7:32 PM
Unknown Object (File)
Nov 13 2025, 5:55 AM
Unknown Object (File)
Nov 10 2025, 10:39 PM
Unknown Object (File)
Nov 4 2025, 3:31 PM
Subscribers

Details

Summary

The day-of-week calculation used the raw year value without adjusting
for TM_YEAR_BASE, so it was off by one for 300 years out of every 400;
it just happened to be correct for 1901 through 2000. It also used a
loop where a simple addition would have sufficed.

While here, simplify our version of Gauss's algorithm, and document
that we assume the Gregorian calendar.

MFC after: 1 week
PR: 282916

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Dec 7 2024, 1:35 PM
This revision is now accepted and ready to land.Dec 7 2024, 1:59 PM

Looks good! Thank you for the test case. :-)

This revision was automatically updated to reflect the committed changes.