Page MenuHomeFreeBSD

strptime: Fix day-of-week calculation.
ClosedPublic

Authored by des on Dec 7 2024, 1:35 PM.
Tags
None
Referenced Files
F171166976: D47977.id147677.diff
Wed, Sep 9, 4:37 AM
F171135586: D47977.diff
Tue, Sep 8, 10:31 PM
Unknown Object (File)
Wed, Sep 2, 2:19 AM
Unknown Object (File)
Tue, Sep 1, 8:12 PM
Unknown Object (File)
Sat, Aug 22, 3:16 PM
Unknown Object (File)
Tue, Aug 18, 9:18 AM
Unknown Object (File)
Wed, Aug 12, 10:27 PM
Unknown Object (File)
Tue, Aug 11, 5:43 AM
Subscribers

Details

Summary

The day-of-week calculation used the raw year value without adjusting
for TM_YEAR_BASE, so it was off by one for 300 years out of every 400;
it just happened to be correct for 1901 through 2000. It also used a
loop where a simple addition would have sufficed.

While here, simplify our version of Gauss's algorithm, and document
that we assume the Gregorian calendar.

MFC after: 1 week
PR: 282916

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61023
Build 57907: arc lint + arc unit

Event Timeline

des requested review of this revision.Dec 7 2024, 1:35 PM
This revision is now accepted and ready to land.Dec 7 2024, 1:59 PM

Looks good! Thank you for the test case. :-)

This revision was automatically updated to reflect the committed changes.