Page MenuHomeFreeBSD
Differential D50297

bsdinstall: Use a login shell for final configuration.
ClosedPublic
Actions

Authored by des on May 11 2025, 2:50 PM.
Tags
None
Referenced Files
F120571855: D50297.id155286.diff
Thu, Jun 19, 6:35 AM
Unknown Object (File)
Tue, Jun 17, 3:13 PM
Unknown Object (File)
Mon, Jun 16, 2:30 PM
Unknown Object (File)
Mon, Jun 2, 11:21 AM
Unknown Object (File)
Sun, Jun 1, 11:52 AM
Unknown Object (File)
Wed, May 28, 7:00 PM
Unknown Object (File)
Wed, May 28, 3:18 PM
Unknown Object (File)
Mon, May 26, 10:17 AM
View All 15 Files
Subscribers
emaste
grahamperrin
imp
jrtc27

Details

Reviewers
allanjude
jrtc27
emaste
Commits
rG95223d920aea: bsdinstall: Use a login shell for final configuration.
rG242b52ba3c38: bsdinstall: Use a login shell for final configuration.
rG5870d6a1ef4e: bsdinstall: Use a login shell for final configuration.
Summary

If the user accepts our offer of a shell to perform final configuration
tasks before rebooting, start a login shell. This ensures it will have
the correct PATH and be able to install packages without issues.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.May 11 2025, 2:50 PM
Herald added subscribers: jrtc27, imp. · View Herald TranscriptMay 11 2025, 2:50 PM
des requested review of this revision.May 11 2025, 2:50 PM
Harbormaster completed remote builds in B64082: Diff 155286.May 11 2025, 2:50 PM
des added a subscriber: grahamperrin.May 11 2025, 2:57 PM
allanjude accepted this revision.May 11 2025, 3:19 PM
This revision is now accepted and ready to land.May 11 2025, 3:19 PM
allanjude requested changes to this revision.May 11 2025, 3:21 PM
This revision now requires changes to proceed.May 11 2025, 3:21 PM
allanjude added inline comments.May 11 2025, 3:22 PM
usr.sbin/bsdinstall/scripts/auto
412

would /usr/bin/login -f root not be better to accomplish this?

emaste added a subscriber: emaste.May 11 2025, 3:46 PM
des added inline comments.May 11 2025, 3:50 PM
usr.sbin/bsdinstall/scripts/auto
412

I guess, but this seemed less risky. Also, login has additional side effects, like updating utmpx.

allanjude accepted this revision.May 11 2025, 3:55 PM

I didn't realize we had added -l to /bin/sh.

LGTM

This revision is now accepted and ready to land.May 11 2025, 3:55 PM
jrtc27 accepted this revision.May 11 2025, 4:13 PM

Seems sensible to me

emaste accepted this revision.May 11 2025, 4:15 PM

Ah, -l is less than a year old (65f5dd42f11cdcb7716e6cdd09fac2314c144c1f)

des marked an inline comment as done.May 11 2025, 8:59 PM
Closed by commit rG5870d6a1ef4e: bsdinstall: Use a login shell for final configuration. (authored by des). · Explain WhyMay 11 2025, 9:05 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG5870d6a1ef4e: bsdinstall: Use a login shell for final configuration..
des added a commit: rG242b52ba3c38: bsdinstall: Use a login shell for final configuration..May 14 2025, 9:09 AM
des added a commit: rG95223d920aea: bsdinstall: Use a login shell for final configuration..May 14 2025, 6:08 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
bsdinstall/
scripts/
2 lines

Diff 155303

View Options

usr.sbin/bsdinstall/scripts/auto

Loading...