yes: Completely overengineer
Needs ReviewPublic
Actions

Authored by des on Mon, Mar 2, 3:55 PM.

Details

Reviewers

gahr

Group Reviewers

Klara

Summary

If we're going to overengineer this, we may as well go all the way.
Well, most of the way. I didn't feel like adding long options.

Add a getopt() loop and a usage message.

If multiple arguments are given, concatenate them into a space- separated list like GNU coreutils does.

When duplicating the expletive, do so exponentially.

Most importantly, don't modify the memory that argv points to.

This will now behave mostly like GNU coreutils, except for the absence
of the --help and --version options.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71151
Build 68034: arc lint + arc unit

Event Timeline

des created this revision.Mon, Mar 2, 3:55 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptMon, Mar 2, 3:55 PM

des requested review of this revision.Mon, Mar 2, 3:55 PM

Harbormaster completed remote builds in B71134: Diff 173016.Mon, Mar 2, 3:55 PM

drop ktrace

Harbormaster completed remote builds in B71135: Diff 173017.Mon, Mar 2, 3:57 PM

des edited the summary of this revision. (Show Details)Mon, Mar 2, 3:57 PM

des added a reviewer: gahr.

drop debugging printf

Harbormaster completed remote builds in B71136: Diff 173018.Mon, Mar 2, 3:59 PM

This changes yes -foo from emitting -foo to an error. Do we really want that for the sake of compatibility with GNU's version?

gahr requested changes to this revision.Mon, Mar 2, 10:06 PM

This revision now requires changes to proceed.Mon, Mar 2, 10:06 PM

gahr added inline comments.Mon, Mar 2, 10:07 PM

usr.bin/yes/yes.c
95	Leftover?

In D55617#1272796, @gahr wrote:

This changes yes -foo from emitting -foo to an error. Do we really want that for the sake of compatibility with GNU's version?

That's not just “compatibility with GNU”, it's consistency with our other command-line utilities (except df and echo, which are special for historical reasons).