Clean up compiler warnings in sysctl(8)

[trasz]

Summary

Clean up compiler warnings in sysctl(8).

[trasz]

Fix MIPS.

[trasz]

(Tinderboxed.)

[trasz]

Pacify gcc, just in case.

[cem]

Mostly LGTM, thanks.

sbin/sysctl/sysctl.c

738

The second (struct efi_md *) cast can be dropped. It is redundant.

907

Alternatively, just memcpy(kind, buf, sizeof(*kind)); here and drop the other changes to this function.

sys/sys/efi.h

96

The second struct efi_md * cast is redundant here as well, unless something is directly acting on this macro like: efi_next_descriptor(...)->md_phys. Which, I hope not.

[imp]

sbin/sysctl/sysctl.c

940–941

Is this still needed?

[trasz]

Fix issues pointed out by cem@.

[trasz]

sbin/sysctl/sysctl.c

940–941

Unfortunately yes, even with new GCC.

sys/sys/efi.h

96

I think I'd rather leave it for now, quick grep shows nobody uses it like that, but it is a valid way to call it.