Clean up compiler warnings in sysctl(8).
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 30724 Build 28452: arc lint + arc unit
Event Timeline
Comment Actions
Mostly LGTM, thanks.
sbin/sysctl/sysctl.c | ||
---|---|---|
738 | The second (struct efi_md *) cast can be dropped. It is redundant. | |
907 | Alternatively, just memcpy(kind, buf, sizeof(*kind)); here and drop the other changes to this function. | |
sys/sys/efi.h | ||
96 | The second struct efi_md * cast is redundant here as well, unless something is directly acting on this macro like: efi_next_descriptor(...)->md_phys. Which, I hope not. |
sbin/sysctl/sysctl.c | ||
---|---|---|
940โ941 | Is this still needed? |