Inline userret() in syscallret()
AbandonedPublic
Actions

Authored by trasz on Oct 1 2020, 12:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 17, 6:15 PM

	Unknown Object (File)
	Sun, Nov 17, 12:36 PM

	Unknown Object (File)
	Oct 2 2024, 4:38 AM

	Unknown Object (File)
	Sep 29 2024, 12:23 AM

	Unknown Object (File)
	Sep 28 2024, 11:02 PM

	Unknown Object (File)
	Sep 27 2024, 9:37 AM

	Unknown Object (File)
	Sep 24 2024, 12:29 AM

	Unknown Object (File)
	Sep 21 2024, 5:03 AM

View All 33 Files

Subscribers

imp

Details

Reviewers

kib

Summary

Inline userret() in syscallret(). When built without debug, the quick patch through this function is about 10 instructions long.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	sys/kern/subr_syscall.c:319	SPELL1	Possible Spelling Mistake

Unit

No Test Coverage

Build Status

Buildable 33919
Build 31119: arc lint + arc unit

Event Timeline

trasz created this revision.Oct 1 2020, 12:24 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 1 2020, 12:24 PM

trasz requested review of this revision.Oct 1 2020, 12:24 PM

Harbormaster completed remote builds in B33919: Diff 77719.Oct 1 2020, 12:24 PM

trasz edited the summary of this revision. (Show Details)Oct 3 2020, 12:05 PM

trasz added a reviewer: kib.

I do not like that subr_trap.c starts including whole subr_syscall.c. Perhaps add subr_userret.c for your function.

P.S. Do not include subr_userret.c from subr_syscall.c, explicitly add needed include in all subr_syscall.c consumers.

trasz abandoned this revision.Mar 22 2024, 9:22 AM

Revision Contents
Changeset List

Path

Size

sys/

kern/

subr_syscall.c

117 lines

subr_trap.c

100 lines

Diff 77719

View Options

sys/kern/subr_syscall.c