Page MenuHomeFreeBSD
Differential D26624

Inline userret() in syscallret()
AbandonedPublic
Actions

Authored by trasz on Oct 1 2020, 12:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 6:27 PM
Unknown Object (File)
Thu, Apr 18, 6:17 AM
Unknown Object (File)
Tue, Apr 16, 2:33 PM
Unknown Object (File)
Tue, Apr 16, 3:33 AM
Unknown Object (File)
Thu, Apr 11, 11:55 PM
Unknown Object (File)
Thu, Apr 11, 6:48 PM
Unknown Object (File)
Thu, Apr 11, 6:48 PM
Unknown Object (File)
Thu, Apr 11, 6:48 PM
View All 13 Files
Subscribers
imp

Details

Reviewers
kib
Summary

Inline userret() in syscallret(). When built without debug, the quick patch through this function is about 10 instructions long.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsys/kern/subr_syscall.c:319SPELL1Possible Spelling Mistake
Unit
No Test Coverage
Build Status
Buildable 33919
Build 31119: arc lint + arc unit

Event Timeline

trasz created this revision.Oct 1 2020, 12:24 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 1 2020, 12:24 PM
trasz requested review of this revision.Oct 1 2020, 12:24 PM
Harbormaster completed remote builds in B33919: Diff 77719.Oct 1 2020, 12:24 PM
trasz edited the summary of this revision. (Show Details)Oct 3 2020, 12:05 PM
trasz added a reviewer: kib.
kib added a comment.Oct 9 2020, 4:43 AM

I do not like that subr_trap.c starts including whole subr_syscall.c. Perhaps add subr_userret.c for your function.

P.S. Do not include subr_userret.c from subr_syscall.c, explicitly add needed include in all subr_syscall.c consumers.

trasz abandoned this revision.Mar 22 2024, 9:22 AM

Revision Contents
Changeset List

PathSize
sys/
kern/
117 lines
100 lines

Diff 77719

View Options

sys/kern/subr_syscall.c

Loading...
View Options

sys/kern/subr_trap.c

Loading...