linux: use sa_family_t for address family conversions
ClosedPublic
Actions

Authored by glebius on Mar 15 2024, 6:41 PM.

Details

Reviewers

dchagin
melifaro

Commits

rG9d4a08d162d8: linux: use sa_family_t for address family conversions

Summary

Express "conversion failed" with maximum possible value. This allows to
reduce number of size/signedness conversion in the code that utilizes the
functions.

PR: 274536 (related)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Mar 15 2024, 6:41 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 15 2024, 6:41 PM

glebius requested review of this revision.Mar 15 2024, 6:41 PM

Harbormaster completed remote builds in B56629: Diff 135794.Mar 15 2024, 6:41 PM

trasz added a subscriber: trasz.Mar 16 2024, 2:20 PM

trasz added inline comments.

sys/compat/linux/linux_netlink.c
109 ↗	(On Diff #135794)	Is this bit supposed to be here? Looks like it's some routing table index, not an address family?

glebius added inline comments.Mar 16 2024, 3:40 PM

sys/compat/linux/linux_netlink.c
109 ↗	(On Diff #135794)	AFAIU, the (int)-1 returned by linux_to_bsd_domain() would convert into 255 when assigned to (unsigned char)rtm->rtm_table. Thus, 254 seems like a typo to me. I can separate that into a single commit.