Page MenuHomeFreeBSD

IfAPI: hide struct ifaddr from if_foreach_addr_type() callbacks
Needs ReviewPublic

Authored by glebius on Dec 12 2024, 2:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 6, 1:14 PM
Unknown Object (File)
Sun, Oct 5, 5:38 AM
Unknown Object (File)
Thu, Sep 25, 12:12 PM
Unknown Object (File)
Tue, Sep 23, 10:21 PM
Unknown Object (File)
Thu, Sep 18, 1:53 AM
Unknown Object (File)
Wed, Sep 17, 10:38 PM
Unknown Object (File)
Sep 9 2025, 6:22 AM
Unknown Object (File)
Aug 25 2025, 3:21 PM

Details

Reviewers
bz
jhibbits
Group Reviewers
network
Restricted Owners Package(Owns No Changed Paths)
Summary

struct ifaddr is an internal structure, just like ifnet. The IfAPI
should keep it opaque from drivers.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61112
Build 57996: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Dec 12 2024, 2:12 PM
In D48054#1101622, @krzysztof.galazka_intel.com wrote:

LGTM but let me ask @bartosz.sobczak_intel.com to take a look at irdma changes.

Thanks! This is the part I can't test, so will really appreciate.

In D48054#1101622, @krzysztof.galazka_intel.com wrote:

LGTM but let me ask @bartosz.sobczak_intel.com to take a look at irdma changes.

Thanks! This is the part I can't test, so will really appreciate.

Visually looks fine. let us run a test or two.