Page MenuHomeFreeBSD
Differential D48054

IfAPI: hide struct ifaddr from if_foreach_addr_type() callbacks
Needs ReviewPublic
Actions

Authored by glebius on Dec 12 2024, 2:12 PM.
Tags
None
Referenced Files
F113019417: D48054.diff
Tue, Mar 25, 11:36 AM
Unknown Object (File)
Fri, Mar 7, 1:40 AM
Unknown Object (File)
Tue, Mar 4, 9:18 AM
Unknown Object (File)
Feb 21 2025, 6:14 AM
Unknown Object (File)
Feb 20 2025, 10:05 PM
Unknown Object (File)
Jan 31 2025, 7:59 AM
Unknown Object (File)
Jan 26 2025, 4:12 AM
Unknown Object (File)
Jan 26 2025, 2:53 AM
View All 14 Files
Subscribers
ae
bartosz.sobczak_intel.com
imp
krzysztof.galazka_intel.com
melifaro

Details

Reviewers
bz
jhibbits
Group Reviewers
network
Restricted Owners Package(Owns No Changed Paths)
Summary

struct ifaddr is an internal structure, just like ifnet. The IfAPI
should keep it opaque from drivers.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61112
Build 57996: arc lint + arc unit

Event Timeline

glebius created this revision.Dec 12 2024, 2:12 PM
Owners added a reviewer: Restricted Owners Package.Dec 12 2024, 2:12 PM
Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptDec 12 2024, 2:12 PM
glebius requested review of this revision.Dec 12 2024, 2:12 PM
Harbormaster completed remote builds in B61112: Diff 147857.Dec 12 2024, 2:12 PM
glebius added a parent revision: D48053: xen/netfront: use iflladdr_event to send ARPs.Dec 12 2024, 2:12 PM
ehem_freebsd_m5p.com mentioned this in D48053: xen/netfront: use iflladdr_event to send ARPs.Dec 12 2024, 9:33 PM
krzysztof.galazka_intel.com added subscribers: bartosz.sobczak_intel.com, krzysztof.galazka_intel.com.Jan 3 2025, 2:08 PM

LGTM but let me ask @bartosz.sobczak_intel.com to take a look at irdma changes.

glebius added a comment.Jan 3 2025, 5:58 PM
In D48054#1101622, @krzysztof.galazka_intel.com wrote:

LGTM but let me ask @bartosz.sobczak_intel.com to take a look at irdma changes.

Thanks! This is the part I can't test, so will really appreciate.

bartosz.sobczak_intel.com added a comment.Jan 13 2025, 12:58 PM
In D48054#1101719, @glebius wrote:
In D48054#1101622, @krzysztof.galazka_intel.com wrote:

LGTM but let me ask @bartosz.sobczak_intel.com to take a look at irdma changes.

Thanks! This is the part I can't test, so will really appreciate.

Visually looks fine. let us run a test or two.

jhibbits accepted this revision.Feb 9 2025, 5:12 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linux/
4 lines
5 lines
dev/
irdma/
16 lines
1 line
13 lines
qlnx/
qlnxr/
6 lines
net/
2 lines
2 lines
nfs/
4 lines
ofed/
drivers/
infiniband/
core/
46 lines
ulp/
ipoib/
6 lines
include/
rdma/
5 lines

Diff 147857

View Options

sys/compat/linux/linux.c

Loading...
View Options

sys/compat/linux/linux_ioctl.c

Loading...
View Options

sys/dev/irdma/fbsd_kcompat.c

Loading...
View Options

sys/dev/irdma/irdma_cm.h

Loading...
View Options

sys/dev/irdma/irdma_cm.c

Loading...
View Options

sys/dev/qlnx/qlnxr/qlnxr_os.c

Loading...
View Options

sys/net/if.c

Loading...
View Options

sys/net/if_var.h

Loading...
View Options

sys/nfs/bootp_subr.c

Loading...
View Options

sys/ofed/drivers/infiniband/core/ib_roce_gid_mgmt.c

Loading...
View Options

sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c

Loading...
View Options

sys/ofed/include/rdma/ib_addr.h

Loading...