Page MenuHomeFreeBSD

website: Rework the downloads table
AbandonedPublic

Authored by trasz on Jan 22 2022, 6:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 3, 6:53 AM
Unknown Object (File)
Wed, Jul 3, 5:17 AM
Unknown Object (File)
Fri, Jun 28, 8:18 AM
Unknown Object (File)
Jun 20 2024, 11:15 PM
Unknown Object (File)
Jun 20 2024, 5:32 PM
Unknown Object (File)
Jun 20 2024, 12:25 PM
Unknown Object (File)
May 27 2024, 12:12 AM
Unknown Object (File)
May 5 2024, 2:14 AM

Details

Reviewers
carlavilla
debdrup
Group Reviewers
docs
doceng
releng
Summary

To me, the new one makes it much easier to find what I need.
In particular it doesn't force the user to browse directory
listings. But this might be just me, so any feedback is welcome.

I've only done this for the first of the tables; I'd rather get some
feedback before spending time on reworking the rest.

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 44059
Build 40947: arc lint + arc unit

Event Timeline

trasz requested review of this revision.Jan 22 2022, 6:36 PM
trasz created this revision.

I honestly can't judge ease of navigation and discoverability based on the AsciiDoc change. Is there an HTML preview version somewhere, or do I have to roll my own? (The latter may take me a few days to a week, but it's an option.)

Shouldn't you also be changing things for 12.3-RELEASE?

Preview: https://people.freebsd.org/~trasz/where.html

And yes, I'll update the other tables too, once I'm convinced to not discard the idea instead :-)

carlavilla added a subscriber: carlavilla.

Personally, I like this approach. Wait until more please share their thoughts :)

This revision is now accepted and ready to land.Jan 25 2022, 9:09 PM

I think this is an improvement indeed. I think we should probably call it "Install Media Image" or something like that rather than "Disk Image", i.e. the fact that the given images are used to install is the key piece.

I think there are other improvements to be made here over time but this is a good start.

It also seems the rendered example has some other changes (e.g. the text "FreeBSD is released for a number of hardware platforms, each in number of different formats including USB memory stick images" doesn't appear in this review)

Yeah, I'll submit the other changes for separate reviews.

Regarding "Installer images" - problem is, not all of those are installer images. I wonder if I should perhaps split off SD card images like it was before...

Also: is there a way to make cells vertically aligned up, as opposed to vertically centered, as it is now? The example from AsciiDoc didn't seem to work for some reason.

Yeah, I'll submit the other changes for separate reviews.

Regarding "Installer images" - problem is, not all of those are installer images. I wonder if I should perhaps split off SD card images like it was before...

Also: is there a way to make cells vertically aligned up, as opposed to vertically centered, as it is now? The example from AsciiDoc didn't seem to work for some reason.

I'm a bit confused about what you mean by installer image vs cd images - if I look at https://www.freebsd.org/where/#download-rel130 the SD card images are separate from the installer images.

I think we're gonna have to ask @carlavilla - I spent some time trying to figure out why the AsciiDoc example (I assume that's the one you're talking about) isn't working, but don't really have a clue except that it might be in doc/website/themes/beastie/layouts?

Yeah, I'll submit the other changes for separate reviews.

Regarding "Installer images" - problem is, not all of those are installer images. I wonder if I should perhaps split off SD card images like it was before...

Also: is there a way to make cells vertically aligned up, as opposed to vertically centered, as it is now? The example from AsciiDoc didn't seem to work for some reason.

I'm a bit confused about what you mean by installer image vs cd images - if I look at https://www.freebsd.org/where/#download-rel130 the SD card images are separate from the installer images.

Right - and in the table this patch introduces they are no longer separate. I've tried with additional column, but that looks weird - it becomes both overcrowded and sparse at the same time.

I think we're gonna have to ask @carlavilla - I spent some time trying to figure out why the AsciiDoc example (I assume that's the one you're talking about) isn't working, but don't really have a clue except that it might be in doc/website/themes/beastie/layouts?

Yeah. I've tried to inspect the resulting web page, but I have no idea where the vertical centering comes from; I also have no idea why the top margin within the table cell looks somewhat larger than I'd like it to be.

Generally speaking, at this time, my main problem with this layout is that it's _huge_. Even a single table like this looks big, and we'd need six of those.

Yeah, I'll submit the other changes for separate reviews.

Regarding "Installer images" - problem is, not all of those are installer images. I wonder if I should perhaps split off SD card images like it was before...

Also: is there a way to make cells vertically aligned up, as opposed to vertically centered, as it is now? The example from AsciiDoc didn't seem to work for some reason.

I'm a bit confused about what you mean by installer image vs cd images - if I look at https://www.freebsd.org/where/#download-rel130 the SD card images are separate from the installer images.

Right - and in the table this patch introduces they are no longer separate. I've tried with additional column, but that looks weird - it becomes both overcrowded and sparse at the same time.

I think we're gonna have to ask @carlavilla - I spent some time trying to figure out why the AsciiDoc example (I assume that's the one you're talking about) isn't working, but don't really have a clue except that it might be in doc/website/themes/beastie/layouts?

Yeah. I've tried to inspect the resulting web page, but I have no idea where the vertical centering comes from; I also have no idea why the top margin within the table cell looks somewhat larger than I'd like it to be.

Generally speaking, at this time, my main problem with this layout is that it's _huge_. Even a single table like this looks big, and we'd need six of those.

If you want, send me an screenshot about what you want and I'll try to help you. Maybe we need to touch the CSS too.

Sorry, I wasn't aware of this D34004 when I worked on D36523, D37307 and D37235.


… vertical centering …

Partly related (some overlap):

– taken by @carlavilla (thanks).

What is the status of this? Is anyone still working on it?
A lot of people comment on this table still needing improvements.