Page MenuHomeFreeBSD

Questionable optimization for riscv cpu_fetch_syscall_args()
Changes PlannedPublic

Authored by trasz on Nov 7 2020, 6:16 PM.

Details

Reviewers
None
Group Reviewers
riscv
Summary

XXX: stashed for later

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 34696
Build 31760: arc lint + arc unit

Event Timeline

trasz requested review of this revision.Nov 7 2020, 6:16 PM
trasz planned changes to this revision.Nov 7 2020, 6:17 PM
trasz planned changes to this revision.Nov 8 2020, 6:31 PM
jhb added inline comments.
sys/riscv/riscv/trap.c
117

Why add this check for nosys? Checking sa_code should be sufficient?

119

This is now missing validation of sa->code and also doesn't update callp. Presumably this has broken any uses of syscall(2)?