Page MenuHomeFreeBSD
Differential D29529

x86: remove gcov kernel support//config(8): remove support for -p
ClosedPublic
Actions

Authored by kib on Apr 1 2021, 9:11 AM.
Tags
None
Referenced Files
F137774621: D29529.diff
Tue, Nov 25, 5:32 PM
Unknown Object (File)
Wed, Nov 19, 1:22 AM
Unknown Object (File)
Sun, Nov 9, 3:41 AM
Unknown Object (File)
Fri, Nov 7, 2:11 AM
Unknown Object (File)
Sun, Nov 2, 1:09 AM
Unknown Object (File)
Thu, Oct 30, 8:09 AM
Unknown Object (File)
Tue, Oct 28, 3:22 AM
Unknown Object (File)
Oct 25 2025, 1:35 AM
View All Files
Subscribers
andrew
pfg

Details

Reviewers
jhb
kevans
emaste
gnn
Commits
rG69efe3695d75: config(8): remove support for -p
rGaa3ea612be36: x86: remove gcov kernel support

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Apr 1 2021, 9:11 AM
Herald added a reviewer: gnn. · View Herald TranscriptApr 1 2021, 9:11 AM
kib requested review of this revision.Apr 1 2021, 9:11 AM
jhb added a comment.Apr 1 2021, 5:36 PM

Is there some more glue in sys/conf we can axe as well? Specifically, all the places that check PROFLEVEL?

kib updated this revision to Diff 86708.Apr 1 2021, 8:11 PM

Remove PROF/PROVLEVEL etc from sys/conf Makefile's pieces.

Herald added a subscriber: andrew. · View Herald TranscriptApr 1 2021, 8:11 PM
jhb accepted this revision.Apr 1 2021, 9:23 PM

This revision is now accepted and ready to land.Apr 1 2021, 9:23 PM
Closed by commit rGaa3ea612be36: x86: remove gcov kernel support (authored by kib). · Explain WhyApr 2 2021, 12:50 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rGaa3ea612be36: x86: remove gcov kernel support.
kib added a commit: rG69efe3695d75: config(8): remove support for -p.
pfg added a subscriber: pfg.Apr 3 2021, 10:02 PM

FWIW ....
I read gcov, but sys/gnu/gcov survived. Perhaps it was meant to be gprof?

kib added a comment.Apr 3 2021, 11:15 PM
In D29529#662844, @pfg wrote:

FWIW ....
I read gcov, but sys/gnu/gcov survived. Perhaps it was meant to be gprof?

gnu/gcov is for line coverage not for sampled profiling. I have no idea about its state, and does it work with any modern gcc.

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
14 lines
2 lines
25 lines
10 lines
2 lines
1 line
6 lines
conf/
4 lines
ia32/
2 lines
include/
82 lines
81 lines
linux/
10 lines
linux32/
6 lines
cddl/
dev/
dtrace/
amd64/
3 lines
conf/
2 lines
27 lines
1 line
2 lines
18 lines
1 line
10 lines
3 lines
42 lines
1 line
dev/
hyperv/
vmbus/
amd64/
2 lines
i386/
2 lines
i386/
conf/
5 lines
i386/
14 lines
2 lines
30 lines
4 lines
4 lines
2 lines
2 lines
1 line
include/
82 lines
94 lines
linux/
6 lines
kern/
345 lines
libkern/

Diff 86743

View Options

sys/amd64/amd64/apic_vector.S

Loading...
View Options

sys/amd64/amd64/atpic_vector.S

Loading...
View Options

sys/amd64/amd64/exception.S

Loading...
View Options

sys/amd64/amd64/locore.S

Loading...
View Options

sys/amd64/amd64/prof_machdep.c

Loading...
View Options

sys/amd64/amd64/sigtramp.S

Loading...
View Options

sys/amd64/amd64/support.S

Loading...
View Options

sys/amd64/amd64/xen-locore.S

Loading...
View Options

sys/amd64/conf/NOTES

Loading...
View Options

sys/amd64/ia32/ia32_exception.S

Loading...
View Options

sys/amd64/include/asmacros.h

Loading...
View Options

sys/amd64/include/profile.h

Loading...
View Options

sys/amd64/linux/linux_locore.asm

Loading...
View Options

sys/amd64/linux32/linux32_locore.asm

Loading...
View Options

sys/cddl/dev/dtrace/amd64/dtrace_asm.S

Loading...
View Options

sys/conf/Makefile.arm

Loading...
View Options

sys/conf/files

Loading...
View Options

sys/conf/files.amd64

Loading...
View Options

sys/conf/files.arm

Loading...
View Options

sys/conf/files.arm64

Loading...
View Options

sys/conf/files.i386

Loading...
View Options

sys/conf/files.x86

Loading...
View Options

sys/conf/kern.post.mk

Loading...
View Options

sys/conf/kern.pre.mk

Loading...
View Options

sys/conf/options.i386

Loading...
View Options

sys/dev/hyperv/vmbus/amd64/vmbus_vector.S

Loading...
View Options

sys/dev/hyperv/vmbus/i386/vmbus_vector.S

Loading...
View Options

sys/i386/conf/NOTES

Loading...
View Options

sys/i386/i386/apic_vector.s

Loading...
View Options

sys/i386/i386/atpic_vector.s

Loading...
View Options

sys/i386/i386/exception.s

Loading...
View Options

sys/i386/i386/locore.s

Loading...
View Options

sys/i386/i386/mpboot.s

Loading...
View Options

sys/i386/i386/prof_machdep.c

Loading...
View Options

sys/i386/i386/sigtramp.s

Loading...
View Options

sys/i386/i386/support.s

Loading...
View Options

sys/i386/i386/vm86bios.s

Loading...
View Options

sys/i386/include/asmacros.h

Loading...
View Options

sys/i386/include/profile.h

Loading...
View Options

sys/i386/linux/linux_locore.asm

Loading...
View Options

sys/kern/subr_prof.c

Loading...
View Options

sys/libkern/mcount.c

Loading...