Page MenuHomeFreeBSD
Differential D41925

fusefs: fix some bugs updating atime during close
ClosedPublic
Actions

Authored by asomers on Sep 20 2023, 9:46 PM.
Tags
None
Referenced Files
F162370651: D41925.diff
Sun, Jul 12, 2:21 PM
F162316189: D41925.diff
Sun, Jul 12, 12:13 AM
Unknown Object (File)
Thu, Jul 2, 3:33 AM
Unknown Object (File)
Thu, Jul 2, 3:33 AM
Unknown Object (File)
Thu, Jul 2, 3:33 AM
Unknown Object (File)
Thu, Jul 2, 12:22 AM
Unknown Object (File)
Thu, Jun 25, 7:34 AM
Unknown Object (File)
Mon, Jun 22, 1:36 AM
View All Files
Subscribers
imp

Details

Reviewers
emaste
pfg
Commits
rG2d05cbe00272: fusefs: fix some bugs updating atime during close
rG63c0b60063c7: fusefs: fix some bugs updating atime during close
rG13f188ce0b51: fusefs: fix some bugs updating atime during close
rGfb619c94c679: fusefs: fix some bugs updating atime during close
Summary

When using cached attributes, we must update a file's atime during
close, if it has been read since the last attribute refresh.

  • Don't update atime if we lack write permissions to the file or if the file system is readonly.
  • If the daemon fails our atime update request for any reason, don't report this as a failure for VOP_CLOSE.

PR: 270749
Reported by: Jamie Landeg-Jones <jamie@catflap.org>
MFC after: 1 week
Sponsored by: Axcient

Test Plan

Unit tests added

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
fs/
fuse/
27 lines
tests/
sys/
fs/
fusefs/
2 lines
42 lines
85 lines

Diff 127597

View Options

sys/fs/fuse/fuse_vnops.c

Loading...
View Options

tests/sys/fs/fusefs/access.cc

Loading...
View Options

tests/sys/fs/fusefs/default_permissions.cc

Loading...
View Options

tests/sys/fs/fusefs/read.cc

Loading...