fusefs: fix copy_file_range when extending a file
ClosedPublic
Actions

Authored by asomers on Nov 28 2021, 6:56 PM.

Details

Reviewers

Commits

rG000ce6dee1fa: fusefs: fix copy_file_range when extending a file
rG65d70b3bae0c: fusefs: fix copy_file_range when extending a file

Summary

When copy_file_range extends a file, it must update the cached file
size.

MFC after: 2 weeks

Test Plan

test case added

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Nov 28 2021, 6:56 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 28 2021, 6:56 PM

asomers requested review of this revision.Nov 28 2021, 6:56 PM

Harbormaster completed remote builds in B43013: Diff 99111.Nov 28 2021, 6:56 PM

Looks ok to me, although I really don't know the fuse code,
so I can't say if it is correct.

Thanks for your input, @rmacklem . You're probably the most knowledgeable person about VOP_COPY_FILE_RANGE in general. @pfg , do the fuse changes look good to you?

LGTM

This revision is now accepted and ready to land.Nov 29 2021, 12:26 AM

Closed by commit rG65d70b3bae0c: fusefs: fix copy_file_range when extending a file (authored by asomers). · Explain WhyNov 29 2021, 1:36 AM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rG65d70b3bae0c: fusefs: fix copy_file_range when extending a file.

asomers added a commit: rG000ce6dee1fa: fusefs: fix copy_file_range when extending a file.Dec 14 2021, 10:12 PM

Revision Contents
Changeset List

Path

Size

sys/

fs/

fuse/

fuse_vnops.c

3 lines

tests/

sys/

fs/

fusefs/

copy_file_range.cc

47 lines

Diff 99125

View Options

sys/fs/fuse/fuse_vnops.c