Differential D34753

fusefs: fix two bugs regarding VOP_RECLAIM of the root inode
ClosedPublic
Actions

Authored by asomers on Apr 2 2022, 7:43 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 10, 1:33 AM

	Unknown Object (File)
	Sun, Dec 1, 2:01 PM

	Unknown Object (File)
	Wed, Nov 27, 11:48 AM

	Unknown Object (File)
	Tue, Nov 26, 9:11 PM

	Unknown Object (File)
	Sun, Nov 24, 5:19 PM

	Unknown Object (File)
	Fri, Nov 22, 11:48 PM

	Unknown Object (File)
	Nov 22 2024, 10:37 AM

	Unknown Object (File)
	Nov 18 2024, 8:20 AM

Subscribers

Details

Reviewers

emaste
pfg

Commits

rG4d5fb17274aa: fusefs: fix two bugs regarding VOP_RECLAIM of the root inode
rG507b75ced9fd: fusefs: fix two bugs regarding VOP_RECLAIM of the root inode
rG32273253667b: fusefs: fix two bugs regarding VOP_RECLAIM of the root inode

Summary

We never send FUSE_LOOKUP for the root inode, since its inode number is hard-coded to 1. Therefore, we should not send FUSE_FORGET for it, lest the server see its lookup count fall below 0.

During VOP_RECLAIM, if we are reclaiming the root inode, we must clear the file system's vroot pointer. Otherwise it will be left pointing at a reclaimed vnode, which will cause future VOP_LOOKUP operations to fail. Previously we only cleared that pointer during VFS_UMOUNT. I don't know of any real-world way to trigger this bug.

MFC after: 2 weeks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Apr 2 2022, 7:43 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 2 2022, 7:43 PM

asomers requested review of this revision.Apr 2 2022, 7:43 PM

Harbormaster completed remote builds in B44967: Diff 104511.Apr 2 2022, 7:43 PM

Release root inode even if the server is already detached

Harbormaster completed remote builds in B44972: Diff 104521.Apr 2 2022, 9:34 PM

asomers added reviewers: emaste, pfg.Apr 2 2022, 9:34 PM

LGTM

This revision is now accepted and ready to land.Apr 4 2022, 3:29 AM

Closed by commit rG32273253667b: fusefs: fix two bugs regarding VOP_RECLAIM of the root inode (authored by asomers). · Explain WhyApr 6 2022, 10:18 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rG32273253667b: fusefs: fix two bugs regarding VOP_RECLAIM of the root inode.

asomers added a commit: rG507b75ced9fd: fusefs: fix two bugs regarding VOP_RECLAIM of the root inode.Apr 29 2022, 8:01 PM

asomers added a commit: rG4d5fb17274aa: fusefs: fix two bugs regarding VOP_RECLAIM of the root inode.Aug 20 2022, 12:49 AM

Revision Contents
Changeset List

Path

Size

sys/

fs/

fuse/

19 lines

tests/

sys/

fs/

fusefs/

1 line

dev_fuse_poll.cc

1 line

33 lines

2 lines

Diff 104692

sys/fs/fuse/fuse_vnops.c

Loading...

tests/sys/fs/fusefs/destroy.cc

Loading...

tests/sys/fs/fusefs/dev_fuse_poll.cc

Loading...

tests/sys/fs/fusefs/forget.cc

Loading...

tests/sys/fs/fusefs/lookup.cc

Loading...