Differential D30892

usr.bin/login: send errors to console if syslog isn't running
ClosedPublic
Actions

Authored by arichardson on Jun 25 2021, 10:00 AM.

Tags

None

Referenced Files

	F147819130: D30892.id91867.diff
	Fri, Mar 13, 9:58 PM

	Unknown Object (File)
	Sat, Mar 7, 7:32 PM

	Unknown Object (File)
	Sat, Mar 7, 12:38 PM

	Unknown Object (File)
	Wed, Mar 4, 7:42 PM

	Unknown Object (File)
	Wed, Mar 4, 10:21 AM

	Unknown Object (File)
	Wed, Mar 4, 1:12 AM

	Unknown Object (File)
	Mon, Mar 2, 7:01 AM

	Unknown Object (File)
	Sat, Feb 28, 9:23 PM

Subscribers

None

Details

Reviewers

pfg
bapt
imp

Commits

rG608cb9631239: usr.bin/login: send errors to console if syslog isn't running
rG4d552825eceb: usr.bin/login: send errors to console if syslog isn't running

Summary

I was debugging why login(1) wasn't working as expected on a minimal
MFS_ROOT disk image. This image doesn't have syslogd running so the
warnings were lost and I had to use GDB to find out why login(1) was
not working as expected (missing PAM libraries).

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson requested review of this revision.Jun 25 2021, 10:00 AM

arichardson created this revision.

Harbormaster completed remote builds in B40083: Diff 91335.Jun 25 2021, 10:01 AM

arichardson mentioned this in D30894: syslog(3): log to console if openlog() failed.Jun 25 2021, 10:05 AM

pfg accepted this revision.Jun 25 2021, 3:54 PM

This revision is now accepted and ready to land.Jun 25 2021, 3:54 PM

Closed by commit rG4d552825eceb: usr.bin/login: send errors to console if syslog isn't running (authored by arichardson). · Explain WhyJul 6 2021, 10:07 AM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rG4d552825eceb: usr.bin/login: send errors to console if syslog isn't running.

arichardson added a commit: rG608cb9631239: usr.bin/login: send errors to console if syslog isn't running.Aug 5 2021, 9:27 AM

Revision Contents
Changeset List

Path

Size

usr.bin/

login/

2 lines

Diff 91867

usr.bin/login/login.c

Loading...