Page MenuHomeFreeBSD
Feed Advanced Search

Sun, Apr 25

pfg added a comment to D29917: BeFS support for fstyp command.

Thank you. I will go for the name BeFS because I noticed other things using this name

Yes please. BFS is way too generic and we had experienced name clashes in the past because they were too short. Even better if it could be done consistently, i.e. applied to macros like BFS_OS_NAME_LENGTH and BFS_SUPER_BLOCK_MAGIC1.

Sun, Apr 25, 3:40 PM

Sat, Apr 24

pfg added inline comments to D29917: BeFS support for fstyp command.
Sat, Apr 24, 6:49 AM
pfg added a comment to D29917: BeFS support for fstyp command.

We don't have the naming conflict here, but befs is OK.
FWIW, there is a fuse version which would be useful before considering a kernel version.

Sat, Apr 24, 6:39 AM

Fri, Apr 23

pfg accepted D29933: Fix inode extra time fields overflow..

While the ext_time_t approach is valid and it also consistent with UFS2, it is usually faster to use 32bit values so you *could* use casts. Either way is valid so I won't object.

Fri, Apr 23, 4:23 PM
pfg accepted D29930: Add chr/blk devices support..
Fri, Apr 23, 4:07 PM
pfg accepted D29932: Improve extents verification logic..
Fri, Apr 23, 4:06 PM
pfg accepted D29929: Fix inode birthtime updating..
Fri, Apr 23, 4:04 PM
pfg accepted D29917: BeFS support for fstyp command.

LGTM, but ultimately cem@ is the local expert.

Fri, Apr 23, 3:03 AM

Thu, Apr 22

pfg requested changes to D29932: Improve extents verification logic..

Using all uppercase messages is bad, unless there is a panic.
Otherwise, LGTM.

Thu, Apr 22, 9:04 PM
pfg accepted D29930: Add chr/blk devices support..

LGTM

Thu, Apr 22, 8:54 PM
pfg requested changes to D29933: Fix inode extra time fields overflow..

Do not touch inode.h.

Thu, Apr 22, 8:49 PM
pfg accepted D29931: Invalidate inode extents cache on truncation..
Thu, Apr 22, 8:08 PM
pfg accepted D29929: Fix inode birthtime updating..

Minor knits, otherwise LGTM.

Thu, Apr 22, 8:05 PM
pfg added inline comments to D29917: BeFS support for fstyp command.
Thu, Apr 22, 7:18 PM
pfg added a comment to D29917: BeFS support for fstyp command.

FWIW, I'd like to see OpenBFS (haiku OS) supported some day on FreeBSD, so I find the name confusing. but the support is welcome nevertheless.

Thu, Apr 22, 7:01 PM

Apr 3 2021

pfg added a comment to D29529: x86: remove gcov kernel support//config(8): remove support for -p.

FWIW ....
I read gcov, but sys/gnu/gcov survived. Perhaps it was meant to be gprof?

Apr 3 2021, 10:02 PM
pfg accepted D29566: lpd: Add -F flag to prevent daemonizing.

LGTM, but gad is the expert.

Apr 3 2021, 6:12 PM

Mar 17 2021

pfg added a comment to D29226: SPDX: Add canonical licenses for indirect SPDX references in the tree.

FWIW, I got the BSD-1-Clause License approved by OSI, Approval is not terribly important as we only use it for a couple of files in the tree.
OTOH the very simplistic license would be useful to adopt for source header files (*.h).

Mar 17 2021, 4:54 AM

Feb 20 2021

pfg committed rP566139: math/reduce: Mark broken on i386.
math/reduce: Mark broken on i386
Feb 20 2021, 4:11 AM

Jan 1 2021

pfg closed D27691: add couchdb & amqps to /etc/services.
Jan 1 2021, 1:50 AM
pfg committed R10:978b10d8ef0f: services: reinstate CouchDB and bring amqps (authored by pfg).
services: reinstate CouchDB and bring amqps
Jan 1 2021, 1:50 AM
pfg committed R10:302c387cd604: services: fiz bug introduced in r361898 (authored by pfg).
services: fiz bug introduced in r361898
Jan 1 2021, 12:40 AM

Dec 24 2020

pfg committed rP559189: lang/bsh: use Java 8.
lang/bsh: use Java 8
Dec 24 2020, 8:51 PM
pfg committed rP559045: lang/bsh: update to version 2.1.0.
lang/bsh: update to version 2.1.0
Dec 24 2020, 4:08 AM

Dec 22 2020

pfg accepted D27691: add couchdb & amqps to /etc/services.
Dec 22 2020, 9:12 PM

Dec 21 2020

pfg added inline comments to D27691: add couchdb & amqps to /etc/services.
Dec 21 2020, 5:16 PM

Dec 20 2020

pfg accepted D27691: add couchdb & amqps to /etc/services.

Wow, I should have dropped it by accident: it was surely my intention to keep couchdb in services.

Dec 20 2020, 11:27 PM

Dec 19 2020

pfg added a comment to D26966: login: add a check for a post-condition when exporting the environment.

Looks like export is only ever used in export_pam_environment(), where its return value is ignored.

Dec 19 2020, 3:47 AM
pfg committed rS368778: login(1): when exporting variables check the result of setenv(3).
login(1): when exporting variables check the result of setenv(3)
Dec 19 2020, 3:07 AM
pfg committed rS368777: Revert r368776:.
Revert r368776:
Dec 19 2020, 2:42 AM
pfg closed D26966: login: add a check for a post-condition when exporting the environment.
Dec 19 2020, 2:24 AM
pfg committed rS368776: login(1): when exporting variables check the result of setenv(3).
login(1): when exporting variables check the result of setenv(3)
Dec 19 2020, 2:24 AM
pfg updated the summary of D26966: login: add a check for a post-condition when exporting the environment.
Dec 19 2020, 2:14 AM
pfg retitled D26966: login: add a check for a post-condition when exporting the environment from login: add a check for a precondition when exporting the environment to login: add a check for a post-condition when exporting the environment.
Dec 19 2020, 2:01 AM

Dec 17 2020

pfg closed D23621: Update /etc/services: attempt to bring it to the new century.
Dec 17 2020, 2:54 AM
pfg committed rS368712: /etc/services: attempt to bring the database to this century 2/2..
/etc/services: attempt to bring the database to this century 2/2.
Dec 17 2020, 2:54 AM

Dec 16 2020

pfg committed rP558245: devel/intellij-rubymine: pet portlint.
devel/intellij-rubymine: pet portlint
Dec 16 2020, 9:46 PM
pfg committed rP558244: devel/intellij-rubymine: Update to version 2020.2.
devel/intellij-rubymine: Update to version 2020.2
Dec 16 2020, 9:39 PM
pfg committed rP558207: devel/dmake; update to version 4.13.1.
devel/dmake; update to version 4.13.1
Dec 16 2020, 5:18 AM
pfg committed rP558205: devel/jetbrains-webstorm: update to version 2020.2.
devel/jetbrains-webstorm: update to version 2020.2
Dec 16 2020, 3:54 AM

Dec 15 2020

pfg committed rP558125: devel/libarea: Update to 20191031.
devel/libarea: Update to 20191031
Dec 15 2020, 3:19 AM

Dec 14 2020

pfg committed rP558070: lang/bsh: Use JDK 8..
lang/bsh: Use JDK 8.
Dec 14 2020, 2:11 AM

Dec 7 2020

pfg committed rP557191: science/tfel: drop maintainance.
science/tfel: drop maintainance
Dec 7 2020, 12:34 AM

Nov 7 2020

pfg accepted D23621: Update /etc/services: attempt to bring it to the new century.

For the record: after discussing with Li-Wen Hsu, it has been suggested to wait until after the 12.1 EOL, and I am actually fine with that.

Nov 7 2020, 3:14 AM

Oct 27 2020

pfg accepted D26973: Switch C.UTF-8 as the default locales.
Oct 27 2020, 7:58 PM
pfg requested review of D26966: login: add a check for a post-condition when exporting the environment.
Oct 27 2020, 4:30 AM

Oct 25 2020

pfg added a comment to D26817: cdefs.h: remove intel_compiler support.
In D26817#601100, @imp wrote:
In D26817#601097, @pfg wrote:

First of all: thanks!

I should mention this was actually for a hacked linux binary-based intel compiler.

There exists a native FreeBSD [[ https://software.intel.com/content/www/us/en/develop/tools/system-studio/freebsd.html | Intel System Studio ]]compiler that claims to be GCC compatible which may just work (I tihnk it may be based on clang, but I am not sure).

I keep hearing rumors of this item, but never have been able to get a copy through my friends at Intel. I'll have to send a few emails out to see if I can see if I can get access to one, though it's a fairly low propriety. I suspect, based on a lot of things, that this doesn't actually exist, but I'll poke and prod anyway.

Oct 25 2020, 7:09 PM
pfg updated subscribers of D26817: cdefs.h: remove intel_compiler support.

First of all: thanks!

Oct 25 2020, 6:29 PM
pfg updated the diff for D23621: Update /etc/services: attempt to bring it to the new century.

Re-state krb524

Oct 25 2020, 5:27 PM

Oct 24 2020

pfg updated the diff for D23621: Update /etc/services: attempt to bring it to the new century.

Update with cy's feedback.
This will be committed about a week after 12.2 is released.

Oct 24 2020, 4:52 AM
pfg added a comment to D23621: Update /etc/services: attempt to bring it to the new century.

Thanks, will update soon.

Oct 24 2020, 4:49 AM
pfg updated the diff for D23621: Update /etc/services: attempt to bring it to the new century.

Merge latest current

Oct 24 2020, 1:54 AM

Oct 21 2020

pfg accepted D26882: Allow calendar files to be provided by a port.
Oct 21 2020, 4:44 PM

Oct 9 2020

pfg committed rS366563: MFC r366501:.
MFC r366501:
Oct 9 2020, 5:28 AM

Oct 6 2020

pfg committed rS366501: ext2fs: minor typo..
ext2fs: minor typo.
Oct 6 2020, 9:31 PM

Sep 22 2020

pfg committed rP549614: cad/calculix : update to version 2.17.1.
cad/calculix : update to version 2.17.1
Sep 22 2020, 5:32 PM
pfg committed rP549613: cad/calculix-ccx: Re-enable multithreading with spooles..
cad/calculix-ccx: Re-enable multithreading with spooles.
Sep 22 2020, 5:31 PM

Aug 20 2020

pfg committed rS364417: usr.sbin/fstyp: Fix incorrect pfs_type test in ondisk inode.
usr.sbin/fstyp: Fix incorrect pfs_type test in ondisk inode
Aug 20 2020, 5:18 AM
pfg committed rS364416: extfs: remove redundant little endian conversion..
extfs: remove redundant little endian conversion.
Aug 20 2020, 5:08 AM
pfg committed rP545494: cad/calculix : update to version 2.17.
cad/calculix : update to version 2.17
Aug 20 2020, 3:33 AM

Aug 17 2020

pfg committed rS364308: extfs: remove redundant little endian conversion..
extfs: remove redundant little endian conversion.
Aug 17 2020, 3:06 PM

Aug 11 2020

pfg committed rP544658: New port: textproc/apache-commons-csv.
New port: textproc/apache-commons-csv
Aug 11 2020, 1:31 AM

Jul 30 2020

pfg committed rP543812: lang/bsh: Use JDK 8 to build..
lang/bsh: Use JDK 8 to build.
Jul 30 2020, 5:28 PM
pfg committed rP543805: cad/NASTRAN-95: mark broken.
cad/NASTRAN-95: mark broken
Jul 30 2020, 5:05 PM

Jul 13 2020

pfg added a comment to D25640: sed "y" command bracket balancing check.
In D25640#567601, @pfg wrote:

LGTM however, I would recommend an exp-run. Many times before have sed changes caused trouble in the ports tree to be later reverted.

Yep, I was looking at the svn log of usr.bin/sed/ and noticed quite a few backouts. I agree that exp-run should be done, but even if some ports break those would need to be fixed instead of rejecting this change as it's obvious bug (and yes, gsed agrees).

Jul 13 2020, 11:09 PM
pfg added a comment to D25640: sed "y" command bracket balancing check.

LGTM however, I would recommend an exp-run. Many times before have sed changes caused trouble in the ports tree to be later reverted.

Jul 13 2020, 5:15 PM

Jul 2 2020

pfg accepted D25312: Relax the rule against declaring variables in nested scopes..
Jul 2 2020, 6:45 PM

Jun 18 2020

pfg committed rS362345: services: Add SSDP to service database.
services: Add SSDP to service database
Jun 18 2020, 10:10 PM
pfg accepted D25312: Relax the rule against declaring variables in nested scopes..
Jun 18 2020, 9:18 AM

Jun 7 2020

pfg committed rS361898: services: Add SSDP to service database.
services: Add SSDP to service database
Jun 7 2020, 7:56 PM
pfg accepted D24079: Read commands from stdin when -f - is passed to sed(1).
Jun 7 2020, 2:52 PM
pfg reopened D23621: Update /etc/services: attempt to bring it to the new century.

I plan to re-commit this as soon as FreeBSD 12.2 is released, to avoid a limitation of the build system.

Jun 7 2020, 5:40 AM

May 11 2020

pfg committed rP534959: devel/jetbrains-phpstorm: major update to version 2020.1.1.
devel/jetbrains-phpstorm: major update to version 2020.1.1
May 11 2020, 9:12 PM

May 8 2020

pfg committed rP534319: math/R-cran-BsMD: update to 2020.4.30..
math/R-cran-BsMD: update to 2020.4.30.
May 8 2020, 3:30 AM

May 4 2020

pfg added a comment to D23259: ext2fs: initial support for byteswapping..
In D23259#543516, @fsu wrote:
In D23259#543509, @pfg wrote:

Sorry I meant to approve this:
https://reviews.freebsd.org/D24685

(fsu should have comandeered this one instead of opening a new one)

I did not managed with new diff uploading, diff did not want to attach to this revision.
Seems like, I can attach diffs only to revisions, which were opened by me.
Please correct me if I am wrong or lose something in the Phabricator UI.

May 4 2020, 4:31 PM
pfg abandoned D23259: ext2fs: initial support for byteswapping..

Sorry I meant to approve this:
https://reviews.freebsd.org/D24685

May 4 2020, 4:12 PM
pfg accepted D24685: ext2fs: initial support for byteswapping (was https://reviews.freebsd.org/D23259).
May 4 2020, 4:12 PM ยท PowerPC
pfg accepted D23259: ext2fs: initial support for byteswapping..
May 4 2020, 4:06 PM

Apr 21 2020

pfg committed rP532249: math/reduce-psl update to version 20200301.
math/reduce-psl update to version 20200301
Apr 21 2020, 3:27 AM

Apr 18 2020

pfg committed rP532039: devel/jetbrains-phpstorm: major update to version 2020.1.
devel/jetbrains-phpstorm: major update to version 2020.1
Apr 18 2020, 6:02 PM

Apr 14 2020

pfg added a comment to D13209: linuxulator: Add user xattrs support for i386 and amd64 platforms..

Ping? What's the status of this?

Apr 14 2020, 7:26 PM

Mar 25 2020

pfg accepted D23926: Swap words order instead of bits order on BIG ENDIAN.
Mar 25 2020, 3:20 PM

Mar 24 2020

pfg abandoned D21638: Add kqueue support for ZFS..

Can we close this review now?

Mar 24 2020, 3:19 PM

Mar 22 2020

pfg committed rS359202: MFC r353909, r355192, r355218, r355218, r358506, r359005:.
MFC r353909, r355192, r355218, r355218, r358506, r359005:
Mar 22 2020, 1:40 AM
pfg committed rS359199: MFC r353909, r355192, r355218, r355218, r358506, r359005:.
MFC r353909, r355192, r355218, r355218, r358506, r359005:
Mar 22 2020, 1:23 AM

Mar 19 2020

pfg committed rP528728: devel/jetbrains-phpstorm: Update to version 2019.3.4.
devel/jetbrains-phpstorm: Update to version 2019.3.4
Mar 19 2020, 3:25 PM

Mar 17 2020

pfg added a comment to D24079: Read commands from stdin when -f - is passed to sed(1).

LGTM, but I have no time to test.
Note that this type of changes should be checked with an exxp-run

Mar 17 2020, 4:15 PM

Mar 15 2020

pfg committed rS359005: calendar(1): Updates and corrections for some calendar files..
calendar(1): Updates and corrections for some calendar files.
Mar 15 2020, 12:49 AM
pfg closed D23581: calendar(1): Updates and corrections for calendar files.
Mar 15 2020, 12:49 AM

Mar 14 2020

pfg updated the diff for D23621: Update /etc/services: attempt to bring it to the new century.

Update User Ports, attempting to bring balance with what can actually appear in a UNIX system.

Mar 14 2020, 3:28 PM

Mar 12 2020

pfg committed rS358904: style(9): Fix space after #define..
style(9): Fix space after #define.
Mar 12 2020, 3:57 AM
pfg committed rS358903: MFC r358154 (by delphij).
MFC r358154 (by delphij)
Mar 12 2020, 3:04 AM

Mar 11 2020

pfg committed rS358870: MFC r358154 (by delphij).
MFC r358154 (by delphij)
Mar 11 2020, 5:45 AM
pfg committed rS358869: Remove GNU patch..
Remove GNU patch.
Mar 11 2020, 4:55 AM
pfg committed rS358868: Delete OpenBSD's variant of RCS..
Delete OpenBSD's variant of RCS.
Mar 11 2020, 4:45 AM

Mar 10 2020

pfg accepted D23581: calendar(1): Updates and corrections for calendar files.

I thought cem would want to do the commit.
I've been a bit sick, but I'll commit it this week if no one else does.

Mar 10 2020, 3:08 AM

Mar 4 2020

pfg accepted D23581: calendar(1): Updates and corrections for calendar files.
Mar 4 2020, 9:20 PM

Mar 3 2020

pfg added inline comments to D23926: Swap words order instead of bits order on BIG ENDIAN.
Mar 3 2020, 3:57 PM
pfg accepted D23926: Swap words order instead of bits order on BIG ENDIAN.

LGTM

Mar 3 2020, 2:48 PM
pfg requested changes to D23926: Swap words order instead of bits order on BIG ENDIAN.

The code is rather tricky, it would be convenient to checksum the object code on Little Endian to make sure nothing changes.

Mar 3 2020, 3:25 AM