Page MenuHomeFreeBSD
Feed Advanced Search

Sat, Sep 25

pfg accepted D32141: fusefs: implement FUSE_NO_OPEN_SUPPORT and FUSE_NO_OPENDIR_SUPPORT.

Interesting ... I don't see the old protocol described upstream

Sat, Sep 25, 9:25 PM

Aug 24 2021

pfg committed R11:b076d791c1ae: sysutils/fusefs-xfuse: workaround re-rolled release tag. (authored by pfg).
sysutils/fusefs-xfuse: workaround re-rolled release tag.
Aug 24 2021, 3:44 PM
pfg committed R11:122ebd040ecf: sysutils/fusefs-xfuse: Read-only FUSE server implementing XFS (authored by pfg).
sysutils/fusefs-xfuse: Read-only FUSE server implementing XFS
Aug 24 2021, 1:57 PM

Aug 2 2021

pfg committed R11:0042759b3b67: textproc/apache-commons-csv: update to version 1.9.0 (authored by pfg).
textproc/apache-commons-csv: update to version 1.9.0
Aug 2 2021, 3:44 PM
pfg added a comment to D31383: Fix undefined pointer arithmetic in fread().
In D31383#707328, @pfg wrote:

Good.

Please also take a look at NetBSD's change 1.23, "Avoid undefined behavior in fread(3)".

Ah nice, that avoids the branch inside the loop. Should I apply the NetBSD change instead?

Aug 2 2021, 3:10 PM
pfg accepted D31383: Fix undefined pointer arithmetic in fread().

Please also take a look at NetBSD's change 1.23, "Avoid undefined behavior in fread(3)".

Aug 2 2021, 3:02 PM

Jul 22 2021

pfg committed R10:c384a27805a6: patch: cleanup variable initialization a bit. (authored by pfg).
patch: cleanup variable initialization a bit.
Jul 22 2021, 7:24 PM

Jun 25 2021

pfg accepted D30892: usr.bin/login: send errors to console if syslog isn't running.
Jun 25 2021, 3:54 PM
pfg accepted D30622: fusefs: correctly set lock owner during FUSE_SETLK.
Jun 25 2021, 2:48 AM

Jun 19 2021

pfg accepted D30810: fusefs: ensure that FUSE ops' headers' unique values are actually unique.
Jun 19 2021, 8:38 PM

Jun 16 2021

pfg accepted D30780: fusefs: improve warnings about buggy FUSE servers.
Jun 16 2021, 6:01 PM
pfg accepted D30784: fusefs: support EVFILT_WRITE on /dev/fuse.
Jun 16 2021, 6:01 PM

Jun 15 2021

pfg committed R10:62d555c4e828: fread: improve performance for unbuffered reads (authored by pfg).
fread: improve performance for unbuffered reads
Jun 15 2021, 9:27 PM

Jun 1 2021

pfg committed R10:a45843c8ed7f: fread: improve performance for unbuffered reads (authored by pfg).
fread: improve performance for unbuffered reads
Jun 1 2021, 9:02 PM
pfg closed D30548: fread: improve performance for unbuffered reads.
Jun 1 2021, 9:02 PM

May 31 2021

pfg updated the diff for D30548: fread: improve performance for unbuffered reads.

Remove deprecated unlocking, pointed out by kib

May 31 2021, 1:51 AM

May 30 2021

pfg reclaimed D30548: fread: improve performance for unbuffered reads.

Duh ! I see now.

May 30 2021, 11:59 PM
pfg added inline comments to D30548: fread: improve performance for unbuffered reads.
May 30 2021, 9:36 PM
pfg added a comment to D30548: fread: improve performance for unbuffered reads.
In D30548#686179, @kib wrote:
In D30548#686034, @pfg wrote:
In D30548#686024, @kib wrote:

In principle, the optimization is perhaps useful for unbuffered consumers.

The locking in your patch is incompatible with the FreeBSD implementation. Test the patch in multithreaded program.

Bah .. you are right, I am quite rusty on FreeBSD and I just copy-pasted. This shouldn't have compiled.

It should compile fine, but it cannot work.

What you need to do is to remove the wrong unlock line.

May 30 2021, 9:33 PM
pfg abandoned D30548: fread: improve performance for unbuffered reads.
In D30548#686024, @kib wrote:

In principle, the optimization is perhaps useful for unbuffered consumers.

The locking in your patch is incompatible with the FreeBSD implementation. Test the patch in multithreaded program.

May 30 2021, 3:34 AM

May 29 2021

pfg requested review of D30548: fread: improve performance for unbuffered reads.
May 29 2021, 9:46 PM
pfg committed R11:03cd6812ff6c: math/reduce{-psl}: Update to version 2021-04-13 (authored by pfg).
math/reduce{-psl}: Update to version 2021-04-13
May 29 2021, 1:42 AM

Apr 25 2021

pfg added a comment to D29917: BeFS support for fstyp command.

Thank you. I will go for the name BeFS because I noticed other things using this name

Yes please. BFS is way too generic and we had experienced name clashes in the past because they were too short. Even better if it could be done consistently, i.e. applied to macros like BFS_OS_NAME_LENGTH and BFS_SUPER_BLOCK_MAGIC1.

Apr 25 2021, 3:40 PM

Apr 24 2021

pfg added inline comments to D29917: BeFS support for fstyp command.
Apr 24 2021, 6:49 AM
pfg added a comment to D29917: BeFS support for fstyp command.

We don't have the naming conflict here, but befs is OK.
FWIW, there is a fuse version which would be useful before considering a kernel version.

Apr 24 2021, 6:39 AM

Apr 23 2021

pfg accepted D29933: Fix inode extra time fields overflow..

While the ext_time_t approach is valid and it also consistent with UFS2, it is usually faster to use 32bit values so you *could* use casts. Either way is valid so I won't object.

Apr 23 2021, 4:23 PM
pfg accepted D29930: Add chr/blk devices support..
Apr 23 2021, 4:07 PM
pfg accepted D29932: Improve extents verification logic..
Apr 23 2021, 4:06 PM
pfg accepted D29929: Fix inode birthtime updating..
Apr 23 2021, 4:04 PM
pfg accepted D29917: BeFS support for fstyp command.

LGTM, but ultimately cem@ is the local expert.

Apr 23 2021, 3:03 AM

Apr 22 2021

pfg requested changes to D29932: Improve extents verification logic..

Using all uppercase messages is bad, unless there is a panic.
Otherwise, LGTM.

Apr 22 2021, 9:04 PM
pfg accepted D29930: Add chr/blk devices support..

LGTM

Apr 22 2021, 8:54 PM
pfg requested changes to D29933: Fix inode extra time fields overflow..

Do not touch inode.h.

Apr 22 2021, 8:49 PM
pfg accepted D29931: Invalidate inode extents cache on truncation..
Apr 22 2021, 8:08 PM
pfg accepted D29929: Fix inode birthtime updating..

Minor knits, otherwise LGTM.

Apr 22 2021, 8:05 PM
pfg added inline comments to D29917: BeFS support for fstyp command.
Apr 22 2021, 7:18 PM
pfg added a comment to D29917: BeFS support for fstyp command.

FWIW, I'd like to see OpenBFS (haiku OS) supported some day on FreeBSD, so this support is welcome.

Apr 22 2021, 7:01 PM

Apr 3 2021

pfg added a comment to D29529: x86: remove gcov kernel support//config(8): remove support for -p.

FWIW ....
I read gcov, but sys/gnu/gcov survived. Perhaps it was meant to be gprof?

Apr 3 2021, 10:02 PM
pfg accepted D29566: lpd: Add -F flag to prevent daemonizing.

LGTM, but gad is the expert.

Apr 3 2021, 6:12 PM

Mar 17 2021

pfg added a comment to D29226: SPDX: Add canonical licenses for indirect SPDX references in the tree.

FWIW, I got the BSD-1-Clause License approved by OSI, Approval is not terribly important as we only use it for a couple of files in the tree.
OTOH the very simplistic license would be useful to adopt for source header files (*.h).

Mar 17 2021, 4:54 AM

Feb 20 2021

pfg committed rP566139: math/reduce: Mark broken on i386.
math/reduce: Mark broken on i386
Feb 20 2021, 4:11 AM

Jan 1 2021

pfg closed D27691: add couchdb & amqps to /etc/services.
Jan 1 2021, 1:50 AM
pfg committed R10:978b10d8ef0f: services: reinstate CouchDB and bring amqps (authored by pfg).
services: reinstate CouchDB and bring amqps
Jan 1 2021, 1:50 AM
pfg committed R10:302c387cd604: services: fiz bug introduced in r361898 (authored by pfg).
services: fiz bug introduced in r361898
Jan 1 2021, 12:40 AM

Dec 24 2020

pfg committed rP559189: lang/bsh: use Java 8.
lang/bsh: use Java 8
Dec 24 2020, 8:51 PM
pfg committed rP559045: lang/bsh: update to version 2.1.0.
lang/bsh: update to version 2.1.0
Dec 24 2020, 4:08 AM

Dec 22 2020

pfg accepted D27691: add couchdb & amqps to /etc/services.
Dec 22 2020, 9:12 PM

Dec 21 2020

pfg added inline comments to D27691: add couchdb & amqps to /etc/services.
Dec 21 2020, 5:16 PM

Dec 20 2020

pfg accepted D27691: add couchdb & amqps to /etc/services.

Wow, I should have dropped it by accident: it was surely my intention to keep couchdb in services.

Dec 20 2020, 11:27 PM

Dec 19 2020

pfg added a comment to D26966: login: add a check for a post-condition when exporting the environment.

Looks like export is only ever used in export_pam_environment(), where its return value is ignored.

Dec 19 2020, 3:47 AM
pfg committed rS368778: login(1): when exporting variables check the result of setenv(3).
login(1): when exporting variables check the result of setenv(3)
Dec 19 2020, 3:07 AM
pfg committed rS368777: Revert r368776:.
Revert r368776:
Dec 19 2020, 2:42 AM
pfg closed D26966: login: add a check for a post-condition when exporting the environment.
Dec 19 2020, 2:24 AM
pfg committed rS368776: login(1): when exporting variables check the result of setenv(3).
login(1): when exporting variables check the result of setenv(3)
Dec 19 2020, 2:24 AM
pfg updated the summary of D26966: login: add a check for a post-condition when exporting the environment.
Dec 19 2020, 2:14 AM
pfg retitled D26966: login: add a check for a post-condition when exporting the environment from login: add a check for a precondition when exporting the environment to login: add a check for a post-condition when exporting the environment.
Dec 19 2020, 2:01 AM

Dec 17 2020

pfg closed D23621: Update /etc/services: attempt to bring it to the new century.
Dec 17 2020, 2:54 AM
pfg committed rS368712: /etc/services: attempt to bring the database to this century 2/2..
/etc/services: attempt to bring the database to this century 2/2.
Dec 17 2020, 2:54 AM

Dec 16 2020

pfg committed rP558245: devel/intellij-rubymine: pet portlint.
devel/intellij-rubymine: pet portlint
Dec 16 2020, 9:46 PM
pfg committed rP558244: devel/intellij-rubymine: Update to version 2020.2.
devel/intellij-rubymine: Update to version 2020.2
Dec 16 2020, 9:39 PM
pfg committed rP558207: devel/dmake; update to version 4.13.1.
devel/dmake; update to version 4.13.1
Dec 16 2020, 5:18 AM
pfg committed rP558205: devel/jetbrains-webstorm: update to version 2020.2.
devel/jetbrains-webstorm: update to version 2020.2
Dec 16 2020, 3:54 AM

Dec 15 2020

pfg committed rP558125: devel/libarea: Update to 20191031.
devel/libarea: Update to 20191031
Dec 15 2020, 3:19 AM

Dec 14 2020

pfg committed rP558070: lang/bsh: Use JDK 8..
lang/bsh: Use JDK 8.
Dec 14 2020, 2:11 AM

Dec 7 2020

pfg committed rP557191: science/tfel: drop maintainance.
science/tfel: drop maintainance
Dec 7 2020, 12:34 AM

Nov 7 2020

pfg accepted D23621: Update /etc/services: attempt to bring it to the new century.

For the record: after discussing with Li-Wen Hsu, it has been suggested to wait until after the 12.1 EOL, and I am actually fine with that.

Nov 7 2020, 3:14 AM

Oct 27 2020

pfg accepted D26973: Switch C.UTF-8 as the default locales.
Oct 27 2020, 7:58 PM
pfg requested review of D26966: login: add a check for a post-condition when exporting the environment.
Oct 27 2020, 4:30 AM

Oct 25 2020

pfg added a comment to D26817: cdefs.h: remove intel_compiler support.
In D26817#601100, @imp wrote:
In D26817#601097, @pfg wrote:

First of all: thanks!

I should mention this was actually for a hacked linux binary-based intel compiler.

There exists a native FreeBSD [[ https://software.intel.com/content/www/us/en/develop/tools/system-studio/freebsd.html | Intel System Studio ]]compiler that claims to be GCC compatible which may just work (I tihnk it may be based on clang, but I am not sure).

I keep hearing rumors of this item, but never have been able to get a copy through my friends at Intel. I'll have to send a few emails out to see if I can see if I can get access to one, though it's a fairly low propriety. I suspect, based on a lot of things, that this doesn't actually exist, but I'll poke and prod anyway.

Oct 25 2020, 7:09 PM
pfg updated subscribers of D26817: cdefs.h: remove intel_compiler support.

First of all: thanks!

Oct 25 2020, 6:29 PM
pfg updated the diff for D23621: Update /etc/services: attempt to bring it to the new century.

Re-state krb524

Oct 25 2020, 5:27 PM

Oct 24 2020

pfg updated the diff for D23621: Update /etc/services: attempt to bring it to the new century.

Update with cy's feedback.
This will be committed about a week after 12.2 is released.

Oct 24 2020, 4:52 AM
pfg added a comment to D23621: Update /etc/services: attempt to bring it to the new century.

Thanks, will update soon.

Oct 24 2020, 4:49 AM
pfg updated the diff for D23621: Update /etc/services: attempt to bring it to the new century.

Merge latest current

Oct 24 2020, 1:54 AM

Oct 21 2020

pfg accepted D26882: Allow calendar files to be provided by a port.
Oct 21 2020, 4:44 PM

Oct 9 2020

pfg committed rS366563: MFC r366501:.
MFC r366501:
Oct 9 2020, 5:28 AM

Oct 6 2020

pfg committed rS366501: ext2fs: minor typo..
ext2fs: minor typo.
Oct 6 2020, 9:31 PM

Sep 22 2020

pfg committed rP549614: cad/calculix : update to version 2.17.1.
cad/calculix : update to version 2.17.1
Sep 22 2020, 5:32 PM
pfg committed rP549613: cad/calculix-ccx: Re-enable multithreading with spooles..
cad/calculix-ccx: Re-enable multithreading with spooles.
Sep 22 2020, 5:31 PM

Aug 20 2020

pfg committed rS364417: usr.sbin/fstyp: Fix incorrect pfs_type test in ondisk inode.
usr.sbin/fstyp: Fix incorrect pfs_type test in ondisk inode
Aug 20 2020, 5:18 AM
pfg committed rS364416: extfs: remove redundant little endian conversion..
extfs: remove redundant little endian conversion.
Aug 20 2020, 5:08 AM
pfg committed rP545494: cad/calculix : update to version 2.17.
cad/calculix : update to version 2.17
Aug 20 2020, 3:33 AM

Aug 17 2020

pfg committed rS364308: extfs: remove redundant little endian conversion..
extfs: remove redundant little endian conversion.
Aug 17 2020, 3:06 PM

Aug 11 2020

pfg committed rP544658: New port: textproc/apache-commons-csv.
New port: textproc/apache-commons-csv
Aug 11 2020, 1:31 AM

Jul 30 2020

pfg committed rP543812: lang/bsh: Use JDK 8 to build..
lang/bsh: Use JDK 8 to build.
Jul 30 2020, 5:28 PM
pfg committed rP543805: cad/NASTRAN-95: mark broken.
cad/NASTRAN-95: mark broken
Jul 30 2020, 5:05 PM

Jul 13 2020

pfg added a comment to D25640: sed "y" command bracket balancing check.
In D25640#567601, @pfg wrote:

LGTM however, I would recommend an exp-run. Many times before have sed changes caused trouble in the ports tree to be later reverted.

Yep, I was looking at the svn log of usr.bin/sed/ and noticed quite a few backouts. I agree that exp-run should be done, but even if some ports break those would need to be fixed instead of rejecting this change as it's obvious bug (and yes, gsed agrees).

Jul 13 2020, 11:09 PM
pfg added a comment to D25640: sed "y" command bracket balancing check.

LGTM however, I would recommend an exp-run. Many times before have sed changes caused trouble in the ports tree to be later reverted.

Jul 13 2020, 5:15 PM

Jul 2 2020

pfg accepted D25312: Relax the rule against declaring variables in nested scopes..
Jul 2 2020, 6:45 PM

Jun 18 2020

pfg committed rS362345: services: Add SSDP to service database.
services: Add SSDP to service database
Jun 18 2020, 10:10 PM
pfg accepted D25312: Relax the rule against declaring variables in nested scopes..
Jun 18 2020, 9:18 AM

Jun 7 2020

pfg committed rS361898: services: Add SSDP to service database.
services: Add SSDP to service database
Jun 7 2020, 7:56 PM
pfg accepted D24079: Read commands from stdin when -f - is passed to sed(1).
Jun 7 2020, 2:52 PM
pfg reopened D23621: Update /etc/services: attempt to bring it to the new century.

I plan to re-commit this as soon as FreeBSD 12.2 is released, to avoid a limitation of the build system.

Jun 7 2020, 5:40 AM

May 11 2020

pfg committed rP534959: devel/jetbrains-phpstorm: major update to version 2020.1.1.
devel/jetbrains-phpstorm: major update to version 2020.1.1
May 11 2020, 9:12 PM

May 8 2020

pfg committed rP534319: math/R-cran-BsMD: update to 2020.4.30..
math/R-cran-BsMD: update to 2020.4.30.
May 8 2020, 3:30 AM

May 4 2020

pfg added a comment to D23259: ext2fs: initial support for byteswapping..
In D23259#543516, @fsu wrote:
In D23259#543509, @pfg wrote:

Sorry I meant to approve this:
https://reviews.freebsd.org/D24685

(fsu should have comandeered this one instead of opening a new one)

I did not managed with new diff uploading, diff did not want to attach to this revision.
Seems like, I can attach diffs only to revisions, which were opened by me.
Please correct me if I am wrong or lose something in the Phabricator UI.

May 4 2020, 4:31 PM
pfg abandoned D23259: ext2fs: initial support for byteswapping..

Sorry I meant to approve this:
https://reviews.freebsd.org/D24685

May 4 2020, 4:12 PM
pfg accepted D24685: ext2fs: initial support for byteswapping (was https://reviews.freebsd.org/D23259).
May 4 2020, 4:12 PM ยท PowerPC
pfg accepted D23259: ext2fs: initial support for byteswapping..
May 4 2020, 4:06 PM