Page MenuHomeFreeBSD

fusefs: correctly handle an inode that changes file types
ClosedPublic

Authored by asomers on Dec 6 2021, 5:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 13, 1:18 PM
Unknown Object (File)
Sun, May 12, 11:42 PM
Unknown Object (File)
Sat, May 11, 11:52 AM
Unknown Object (File)
Fri, May 10, 12:41 AM
Unknown Object (File)
Sun, Apr 28, 9:55 AM
Unknown Object (File)
Apr 14 2024, 2:44 AM
Unknown Object (File)
Apr 11 2024, 1:31 PM
Unknown Object (File)
Feb 9 2024, 3:56 PM

Details

Summary

Correctly handle the situation where a FUSE server unlinks a file, then
creates a new file of a different type but with the same inode number.
Previously fuse_vnop_lookup in this situation would return EAGAIN. But
since it didn't call vgone(), the vnode couldn't be reused right away.
Fix this by immediately calling vgone() and reallocating a new vnode.

This problem can occur in three code paths, during VOP_LOOKUP,
VOP_SETATTR, or following FUSE_GETATTR, which usually happens during
VOP_GETATTR but can occur during other vops, too. Note that the correct
response actually doesn't depend on whether the entry cache has expired.
In fact, during VOP_LOOKUP, we can't even tell. Either it has expired
already, or else the vnode got reclaimed by vnlru.

Also, correct the error code during the VOP_SETATTR path.

PR: 258022
Reported by: chogata@moosefs.pro
MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable