Page MenuHomeFreeBSD

fusefs: handle evil servers that return illegal inode numbers
ClosedPublic

Authored by asomers on May 4 2022, 11:40 PM.
Tags
None
Referenced Files
F146469266: D35128.id105907.diff
Mon, Mar 2, 10:54 PM
Unknown Object (File)
Mon, Mar 2, 2:00 PM
Unknown Object (File)
Fri, Feb 27, 7:21 PM
Unknown Object (File)
Mon, Feb 23, 12:49 PM
Unknown Object (File)
Mon, Feb 23, 12:49 PM
Unknown Object (File)
Sun, Feb 22, 5:47 AM
Unknown Object (File)
Sat, Feb 21, 9:27 PM
Unknown Object (File)
Mon, Feb 2, 12:09 AM
Subscribers

Details

Summary

fusefs: handle evil servers that return illegal inode numbers

  • If during FUSE_CREATE, FUSE_MKDIR, etc the server returns the same inode number for the new file as for its parent directory, reject it. Previously this would triggers a recurse-on-non-recursive lock panic.
  • If during FUSE_LINK the server returns a different inode number for the new name as for the old one, reject it. Obviously, that can't be a hard link.
  • If during FUSE_LOOKUP the server returns the same inode number for the new file as for its parent directory, reject it. Nothing good can come of this.

PR: 263662
Reported by: Robert Morris <rtm@lcs.mit.edu>
MFC after: 2 weeks

Test Plan

tests added

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable