Paths

Table of Contentst

Differential D55539

Add renameat(2) and AT_RENAME_NOREPLACE flag for it
Needs ReviewPublic
Actions

Authored by kib on Thu, Feb 26, 7:17 PM.

Tags

None

Referenced Files

	F146038286: D55539.id172787.diff
	Fri, Feb 27, 6:41 AM

	F146034008: D55539.id172803.diff
	Fri, Feb 27, 5:45 AM

	F146030630: D55539.id172807.diff
	Fri, Feb 27, 4:58 AM

	F146024570: D55539.id172787.diff
	Fri, Feb 27, 3:35 AM

Subscribers

Details

Reviewers

brooks
olce

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Thu, Feb 26, 7:17 PM

Herald added a reviewer: brooks. · View Herald TranscriptThu, Feb 26, 7:17 PM

Herald added a reviewer: olce. · View Herald Transcript

Herald added subscribers: olce, asomers, delphij, imp. · View Herald Transcript

kib requested review of this revision.Thu, Feb 26, 7:17 PM

arrowd added a subscriber: arrowd.Thu, Feb 26, 7:36 PM

Document renameat2.

Herald added a subscriber: ziaee. · View Herald TranscriptFri, Feb 27, 12:14 AM

Improve cleanup for failed AT_RENAME_NOREPLACE.
List EOPNOTSUPP in the man page.

Syscall bits look good. A few comments.

lib/libsys/rename.2
135	Or perhaps "call operates identically to"
334–338	Or alternatively something like "...returned by the renameat system call, the renameat2 system call..."
sys/fs/tmpfs/tmpfs_vnops.c
1024	I'm surprised by `~(AT_RENAME_NOREPLACE)` here

Revision Contents
Changeset List

Path

Size

include/

1 line

lib/

libsys/

3 lines

1 line

79 lines

sys/

compat/

freebsd32/

freebsd32_syscall.h

freebsd32_syscalls.c

freebsd32_sysent.c

freebsd32_systrace_args.c

linux/

16 lines

contrib/

openzfs/

module/

os/

freebsd/

zfs/

5 lines

fs/

fuse/

4 lines

msdosfs/

msdosfs_vnops.c

12 lines

nfsclient/

6 lines

nfsserver/

2 lines

nullfs/

3 lines

p9fs/

5 lines

smbfs/

5 lines

tmpfs/

12 lines

unionfs/

7 lines

kern/

syscalls.master

10 lines

systrace_args.c

32 lines

1 line

sys/

3 lines

2 lines

ufs/

ufs/

12 lines

Diff 172807

include/stdio.h

Loading...

lib/libsys/Makefile.sys

Loading...

lib/libsys/Symbol.sys.map

Loading...

lib/libsys/_libsys.h

Loading...

lib/libsys/rename.2

Loading...

lib/libsys/syscalls.map

Loading...

sys/compat/freebsd32/freebsd32_syscall.h

Loading...

sys/compat/freebsd32/freebsd32_syscalls.c

Loading...

sys/compat/freebsd32/freebsd32_sysent.c

Loading...

sys/compat/freebsd32/freebsd32_systrace_args.c

Loading...

sys/compat/linux/linux_file.c

Loading...

sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c

Loading...

sys/fs/fuse/fuse_vnops.c

Loading...

sys/fs/msdosfs/msdosfs_vnops.c

Loading...

sys/fs/nfsclient/nfs_clvnops.c

Loading...

sys/fs/nfsserver/nfs_nfsdport.c

Loading...

sys/fs/nullfs/null_vnops.c

Loading...

sys/fs/p9fs/p9fs_vnops.c

Loading...

sys/fs/smbfs/smbfs_vnops.c

Loading...

sys/fs/tmpfs/tmpfs_vnops.c

Loading...

sys/fs/unionfs/union_vnops.c

Loading...

sys/kern/init_sysent.c

Loading...

sys/kern/syscalls.c

Loading...

sys/kern/syscalls.master

Loading...

sys/kern/systrace_args.c

Loading...

sys/kern/vfs_syscalls.c

Loading...

sys/kern/vnode_if.src

Loading...

sys/sys/fcntl.h

Loading...

sys/sys/syscall.h

Loading...

sys/sys/syscall.mk

Loading...

sys/sys/syscallsubr.h

Loading...

sys/sys/sysproto.h

Loading...

sys/ufs/ufs/ufs_vnops.c

Loading...