Move the PMC overflow count to make it per-CPU
ClosedPublic
Actions

Authored by andrew on Jan 5 2021, 11:54 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Aug 30, 10:46 AM

	Unknown Object (File)
	Thu, Aug 27, 5:27 PM

	Unknown Object (File)
	Wed, Aug 19, 8:36 PM

	Unknown Object (File)
	Wed, Aug 19, 8:36 PM

	Unknown Object (File)
	Sat, Aug 15, 12:27 AM

	Unknown Object (File)
	Fri, Aug 14, 10:05 PM

	Unknown Object (File)
	Mon, Aug 10, 10:17 AM

	Unknown Object (File)
	Sun, Aug 9, 2:30 PM

Subscribers

Details

Reviewers

gnn

Group Reviewers

ARM
arm64
pmc

Commits

rG6815909abdaa: Move the PMC overflow count to make it per-CPU

Summary

Virtual PMCs could be running on multiple CPUs so this needs to be
a per-CPU value.

Submitted by: rwatson (earlier version)
Sponsored by: Innovate UK

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Jan 5 2021, 11:54 AM

Herald added a subscriber: emaste. · View Herald TranscriptJan 5 2021, 11:54 AM

andrew requested review of this revision.Jan 5 2021, 11:54 AM

Harbormaster completed remote builds in B35944: Diff 81669.Jan 5 2021, 11:55 AM

andrew added a parent revision: D27969: Update hwpmc on armv7 to handle overflow better.Jan 5 2021, 11:56 AM

andrew set the repository for this revision to rG FreeBSD src repository.Jan 5 2021, 12:40 PM

LGTM

This revision is now accepted and ready to land.Jan 5 2021, 4:04 PM

Closed by commit rG6815909abdaa: Move the PMC overflow count to make it per-CPU (authored by andrew). · Explain WhyJan 8 2021, 2:30 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG6815909abdaa: Move the PMC overflow count to make it per-CPU.

Revision Contents
Changeset List

Path

Size

sys/

dev/

hwpmc/

hwpmc_arm64.c

8 lines

hwpmc_armv7.c

8 lines

sys/

pmc.h

2 lines

Diff 81881

View Options

sys/dev/hwpmc/hwpmc_arm64.c

View Options

sys/dev/hwpmc/hwpmc_armv7.c

View Options

Move the PMC overflow count to make it per-CPUClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 81881

sys/dev/hwpmc/hwpmc_arm64.c

sys/dev/hwpmc/hwpmc_armv7.c

sys/sys/pmc.h

Move the PMC overflow count to make it per-CPU
ClosedPublic
Actions

Revision Contents
Changeset List