Details
Details
- Reviewers
mhorne gnn ali_mashtizadeh.com - Group Reviewers
pmc
Built amd64 GENERIC + hwpmc.ko, GENERIC without HWPMC_HOOKS, and arm64.
Ran tests/sys/pmc on AMD Zen 6 (LBR v2).
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 78197 Build 75080: arc lint + arc unit
Event Timeline
Comment Actions
I can fix the flag issue and we land my diff and you rebase on top of my branch history interface.
I was thinking to generalize the callback interface so providers like ibs can use it too.
| sys/sys/pmc.h | ||
|---|---|---|
| 991 | This is a problem because it’s on the stack and getting way too big. It’ll be even bigger for Intel and arm’s branch histories. This is why my proposed branch history interface uses a callback mechanism so we can fill in the sample after allocation. | |
Comment Actions
Ali, thank you for the review. Yes, let us wait until your branch history interface lands and I will rebse on it. Just add me in the diff so that I can see when it lands, Thannks!