Page MenuHomeFreeBSD

Fix loading the hwpmc module when ACPI is enabled
ClosedPublic

Authored by andrew on Dec 21 2022, 1:36 PM.
Tags
None
Referenced Files
F109970050: D37773.id114359.diff
Tue, Feb 11, 9:42 PM
Unknown Object (File)
Wed, Jan 15, 1:05 PM
Unknown Object (File)
Wed, Jan 15, 12:41 PM
Unknown Object (File)
Wed, Jan 15, 9:44 AM
Unknown Object (File)
Jan 3 2025, 2:40 PM
Unknown Object (File)
Dec 4 2024, 7:08 AM
Unknown Object (File)
Nov 25 2024, 7:42 AM
Unknown Object (File)
Nov 23 2024, 3:21 AM
Subscribers

Details

Summary

In 0a9a4d2cd6092 a check for OPT_ACPI was added to the hwpmc Makefile
to fix loading the module in a kernel where ACPI has been disabled.
This broke loading the module when ACPI was enabled in the build as
OPT_ACPI isn't a Makefile macro so was always disabled.

Move this check to the C files where the DEV_ACPI macro does exist.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Dec 21 2022, 3:11 PM
sys/arm64/arm64/cmn600.c
1–2

We should update the SPDX tag while here