Page MenuHomeFreeBSD

Fix loading the hwpmc module when ACPI is enabled
ClosedPublic

Authored by andrew on Dec 21 2022, 1:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 7, 8:16 AM
Unknown Object (File)
Fri, Mar 6, 12:53 AM
Unknown Object (File)
Sat, Feb 21, 2:54 AM
Unknown Object (File)
Fri, Feb 20, 9:29 AM
Unknown Object (File)
Thu, Feb 19, 6:16 AM
Unknown Object (File)
Thu, Feb 19, 6:16 AM
Unknown Object (File)
Wed, Feb 18, 10:27 AM
Unknown Object (File)
Jan 20 2026, 6:53 PM
Subscribers

Details

Summary

In 0a9a4d2cd6092 a check for OPT_ACPI was added to the hwpmc Makefile
to fix loading the module in a kernel where ACPI has been disabled.
This broke loading the module when ACPI was enabled in the build as
OPT_ACPI isn't a Makefile macro so was always disabled.

Move this check to the C files where the DEV_ACPI macro does exist.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Dec 21 2022, 3:11 PM
sys/arm64/arm64/cmn600.c
1–2

We should update the SPDX tag while here