Page MenuHomeFreeBSD

firk_cantconnect.ru (firk)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 1 2022, 8:15 AM (111 w, 2 d)

Recent Activity

Nov 28 2023

firk_cantconnect.ru added a comment to D37013: devel/binutils: Add INFO option.
In D37013#975931, @cy wrote:

LGTM.

Prior to commit, can I please have your full name and email address so that I can fill in the --author field?

The subject line and summary have been adjusted to make for a good commit log message.

Nov 28 2023, 5:23 AM

Nov 27 2023

firk_cantconnect.ru retitled D37012: math/mpfr: Add INFO option from Add INFO option to math/mpfr to get rid of unconditional texinfo dependency to math/mpfr: Add INFO option.
Nov 27 2023, 10:40 PM
firk_cantconnect.ru added a comment to D37013: devel/binutils: Add INFO option.
In D37013#975891, @cy wrote:
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: share/info/ctf-spec.info
Error: Orphaned: share/info/sframe-spec.info
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

Stop.
make: stopped in /usr/ports/devel/binutils
Nov 27 2023, 10:37 PM
firk_cantconnect.ru updated the diff for D37013: devel/binutils: Add INFO option.

fix unwanted info files when INFO disabled

Nov 27 2023, 10:35 PM
firk_cantconnect.ru added inline comments to D37013: devel/binutils: Add INFO option.
Nov 27 2023, 6:24 PM
firk_cantconnect.ru updated the diff for D37013: devel/binutils: Add INFO option.
Nov 27 2023, 6:23 PM
firk_cantconnect.ru added a comment to D37013: devel/binutils: Add INFO option.
In D37013#975828, @cy wrote:

/tmp/D37013.diff:50: space before tab in indent.

	$(MAKE) $(AM_MAKEFLAGS) check-recursive
Nov 27 2023, 5:54 PM
firk_cantconnect.ru updated the summary of D37013: devel/binutils: Add INFO option.
Nov 27 2023, 3:54 PM
firk_cantconnect.ru updated the diff for D37013: devel/binutils: Add INFO option.

Rebased the diff to new port version (2.37 -> 2.40)

Nov 27 2023, 3:50 PM
firk_cantconnect.ru updated the summary of D37012: math/mpfr: Add INFO option.
Nov 27 2023, 3:46 PM
firk_cantconnect.ru retitled D37012: math/mpfr: Add INFO option from Add INFO option to math/gmp and math/mpfr to get rid of unconditional texinfo dependency to Add INFO option to math/mpfr to get rid of unconditional texinfo dependency.
Nov 27 2023, 3:38 PM
firk_cantconnect.ru updated the diff for D37012: math/mpfr: Add INFO option.

Because of math/gmp already patched by PR 259573, removing it from my diff.
Also rebased math/mpfr patch to the new version (but it remains nearly the same).

Nov 27 2023, 3:38 PM

Jan 16 2023

firk_cantconnect.ru added a comment to D34557: UNIX-socket bind(): distinguish between alive listening socket and random garbage.

@glebius ?

Jan 16 2023, 12:05 AM · network

Oct 16 2022

firk_cantconnect.ru requested review of D37013: devel/binutils: Add INFO option.
Oct 16 2022, 6:14 PM
firk_cantconnect.ru updated the diff for D37012: math/mpfr: Add INFO option.

added math/mpfr too

Oct 16 2022, 11:07 AM
firk_cantconnect.ru requested review of D37012: math/mpfr: Add INFO option.
Oct 16 2022, 10:43 AM

Oct 13 2022

firk_cantconnect.ru added a comment to D31821: Improve POSIX compliance of listen().

Please note such things:

Oct 13 2022, 4:13 PM

Sep 21 2022

firk_cantconnect.ru updated the diff for D34557: UNIX-socket bind(): distinguish between alive listening socket and random garbage.

Document the change in man pages.

Sep 21 2022, 10:57 PM · network
firk_cantconnect.ru added a comment to D34579: Verify directory fds against chroot when receiving them through SCM_RIGHTS.

I can't see how this can be used maliciously, e.g. forcing some application outside of jail to send its SCM_RIGHTS to a jail.

Sep 21 2022, 9:33 PM · network, Jails, security

Sep 2 2022

firk_cantconnect.ru added a comment to D36272: Fix old semaphore interface race.

with the assumption that client-allocated struct usem is 64-bit aligned

Sep 2 2022, 8:33 AM

Aug 26 2022

firk_cantconnect.ru added a comment to D36272: Fix old semaphore interface race.
In D36272#825614, @kib wrote:

Could you please mail me git format-patch with the change, proper commit log, and author?

Aug 26 2022, 8:39 AM
firk_cantconnect.ru updated the diff for D36272: Fix old semaphore interface race.

removed extra { }

Aug 26 2022, 7:56 AM
firk_cantconnect.ru added inline comments to D36272: Fix old semaphore interface race.
Aug 26 2022, 6:15 AM
firk_cantconnect.ru updated the diff for D36272: Fix old semaphore interface race.

avoid possible race when clearing _has_waiters

Aug 26 2022, 5:53 AM

Aug 20 2022

firk_cantconnect.ru added a comment to D36272: Fix old semaphore interface race.

related: https://reviews.freebsd.org/D20772

Aug 20 2022, 1:27 AM
firk_cantconnect.ru added a reviewer for D36272: Fix old semaphore interface race: kib.
Aug 20 2022, 1:26 AM
firk_cantconnect.ru requested review of D36272: Fix old semaphore interface race.
Aug 20 2022, 1:23 AM

Jul 27 2022

firk_cantconnect.ru updated the diff for D35967: Fix incorrect EADDRINUSE from connect().

fixed file path in diff

Jul 27 2022, 7:41 PM · network
firk_cantconnect.ru requested review of D35967: Fix incorrect EADDRINUSE from connect().
Jul 27 2022, 7:33 PM · network

Jun 3 2022

firk_cantconnect.ru updated subscribers of D34579: Verify directory fds against chroot when receiving them through SCM_RIGHTS.
Jun 3 2022, 10:24 PM · network, Jails, security

May 28 2022

firk_cantconnect.ru added a comment to D34637: Allow realtime and precise accounting of cpu utilization for threads and racct-objects..

@trasz could you please say something about this?

May 28 2022, 9:21 PM · Jails

Mar 30 2022

firk_cantconnect.ru updated the diff for D34637: Allow realtime and precise accounting of cpu utilization for threads and racct-objects..

Found a race between sys_exit() -> exit1() -> thread_exit() and sys_wait() -> proc_reap().
Slightly moving down PROC_SUNLOCK() in thread_exit() to protect RACCT_RT calculations from proc_reap() destroying p->p_racct.

Mar 30 2022, 5:29 AM · Jails

Mar 29 2022

firk_cantconnect.ru added a comment to D34579: Verify directory fds against chroot when receiving them through SCM_RIGHTS.

For example it is possible to share file descriptor tables, and one of the processes may not be encumbered by the jail.

Mar 29 2022, 2:34 PM · network, Jails, security

Mar 28 2022

firk_cantconnect.ru updated subscribers of D34579: Verify directory fds against chroot when receiving them through SCM_RIGHTS.
Mar 28 2022, 9:48 PM · network, Jails, security

Mar 25 2022

firk_cantconnect.ru updated the diff for D34637: Allow realtime and precise accounting of cpu utilization for threads and racct-objects..
Mar 25 2022, 8:56 AM · Jails

Mar 23 2022

firk_cantconnect.ru updated the summary of D34637: Allow realtime and precise accounting of cpu utilization for threads and racct-objects..
Mar 23 2022, 11:25 PM · Jails
firk_cantconnect.ru added inline comments to D34637: Allow realtime and precise accounting of cpu utilization for threads and racct-objects..
Mar 23 2022, 11:22 PM · Jails
firk_cantconnect.ru updated the diff for D34637: Allow realtime and precise accounting of cpu utilization for threads and racct-objects..
Mar 23 2022, 11:19 PM · Jails

Mar 22 2022

firk_cantconnect.ru added a watcher for Jails: firk_cantconnect.ru.
Mar 22 2022, 5:45 PM
firk_cantconnect.ru updated the test plan for D34637: Allow realtime and precise accounting of cpu utilization for threads and racct-objects..
Mar 22 2022, 5:40 PM · Jails
firk_cantconnect.ru updated the summary of D34637: Allow realtime and precise accounting of cpu utilization for threads and racct-objects..
Mar 22 2022, 5:38 PM · Jails
firk_cantconnect.ru requested review of D34637: Allow realtime and precise accounting of cpu utilization for threads and racct-objects..
Mar 22 2022, 5:36 PM · Jails

Mar 19 2022

firk_cantconnect.ru updated the diff for D34558: Fix imprecisions and timestep in cputime counters.

Found same function in lib/libkvm/kvm_proc.c, patch it too.

Mar 19 2022, 4:57 PM

Mar 17 2022

firk_cantconnect.ru updated the test plan for D34559: clock_gettime(CLOCK_THREAD_CPUTIME_ID) was not monotonic due to race.
Mar 17 2022, 7:01 PM
firk_cantconnect.ru added a comment to D34558: Fix imprecisions and timestep in cputime counters.

As for 64/64 divides on 32bit platform: in fact, (nearly) all 32-bit CPUs have a 32-bit tickrate (<4.2GHz), and modern compilers/libraries seems to use 64/32 math in runtime for such a case in 32-bit mode (__udivdi3 function).

Mar 17 2022, 5:11 AM

Mar 16 2022

firk_cantconnect.ru added a comment to D34558: Fix imprecisions and timestep in cputime counters.

I didn't done the test by myself, but this is trivial integer arithmetic.

Mar 16 2022, 10:44 PM
firk_cantconnect.ru added a comment to D34558: Fix imprecisions and timestep in cputime counters.

Is it possible to find out how this was tested?

Mar 16 2022, 10:40 PM
firk_cantconnect.ru updated the test plan for D34558: Fix imprecisions and timestep in cputime counters.
Mar 16 2022, 10:37 PM
firk_cantconnect.ru updated the test plan for D34579: Verify directory fds against chroot when receiving them through SCM_RIGHTS.
Mar 16 2022, 6:59 PM · network, Jails, security
firk_cantconnect.ru added a comment to D34559: clock_gettime(CLOCK_THREAD_CPUTIME_ID) was not monotonic due to race.

Is "firk <firk@cantconnect.ru>" the desired author for the git commit?

Mar 16 2022, 3:04 PM
firk_cantconnect.ru requested review of D34579: Verify directory fds against chroot when receiving them through SCM_RIGHTS.
Mar 16 2022, 10:28 AM · network, Jails, security

Mar 15 2022

firk_cantconnect.ru updated the diff for D34559: clock_gettime(CLOCK_THREAD_CPUTIME_ID) was not monotonic due to race.

simplify things according to replies

Mar 15 2022, 11:52 PM
firk_cantconnect.ru added inline comments to D34559: clock_gettime(CLOCK_THREAD_CPUTIME_ID) was not monotonic due to race.
Mar 15 2022, 11:51 PM
firk_cantconnect.ru retitled D34560: Add mount option to disallow creating sockets on filesystem from Add mount option to disallow creating socketson filesystem to Add mount option to disallow creating sockets on filesystem.
Mar 15 2022, 12:25 AM · security, network, Jails

Mar 14 2022

firk_cantconnect.ru requested review of D34560: Add mount option to disallow creating sockets on filesystem.
Mar 14 2022, 11:28 PM · security, network, Jails
firk_cantconnect.ru requested review of D34559: clock_gettime(CLOCK_THREAD_CPUTIME_ID) was not monotonic due to race.
Mar 14 2022, 11:18 PM
firk_cantconnect.ru requested review of D34558: Fix imprecisions and timestep in cputime counters.
Mar 14 2022, 11:10 PM
firk_cantconnect.ru requested review of D34557: UNIX-socket bind(): distinguish between alive listening socket and random garbage.
Mar 14 2022, 10:58 PM · network