Page MenuHomeFreeBSD

libpmc: eliminate pmc_pmu_stat_mode()
ClosedPublic

Authored by mhorne on May 28 2021, 6:10 PM.

Details

Summary

There is a single consumer, the pmc utility, that clearly has knowledge
of which counters it is expecting. Remove this function and have it
use common counter aliases instead.

No functional change intended.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mhorne added inline comments.
usr.sbin/pmc/cmd_pmc_stat.c
113

Since it is not obvious from the diff, these aliases refer to the same counters as the names being removed above (on intel at least). Therefore, later calls to pmc_allocate() in this file will behave the same.

This revision is now accepted and ready to land.May 28 2021, 7:09 PM
This revision was automatically updated to reflect the committed changes.