Page MenuHomeFreeBSD

libpmc: eliminate pmc_pmu_stat_mode()
ClosedPublic

Authored by mhorne on May 28 2021, 6:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 9:52 AM
Unknown Object (File)
Fri, Nov 15, 9:39 AM
Unknown Object (File)
Fri, Nov 15, 7:44 AM
Unknown Object (File)
Wed, Nov 13, 3:20 PM
Unknown Object (File)
Wed, Nov 13, 4:33 AM
Unknown Object (File)
Oct 24 2024, 8:39 AM
Unknown Object (File)
Sep 30 2024, 11:15 PM
Unknown Object (File)
Sep 23 2024, 9:51 PM
Subscribers

Details

Summary

There is a single consumer, the pmc utility, that clearly has knowledge
of which counters it is expecting. Remove this function and have it
use common counter aliases instead.

No functional change intended.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39543
Build 36432: arc lint + arc unit

Event Timeline

mhorne added inline comments.
usr.sbin/pmc/cmd_pmc_stat.c
114

Since it is not obvious from the diff, these aliases refer to the same counters as the names being removed above (on intel at least). Therefore, later calls to pmc_allocate() in this file will behave the same.

This revision is now accepted and ready to land.May 28 2021, 7:09 PM
This revision was automatically updated to reflect the committed changes.