Paths

Table of Contentst

Differential D45412

tcp: remove unused code in tcp_usr_attach
ClosedPublic
Actions

Authored by tuexen on Thu, May 30, 1:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jun 1, 5:14 PM

	Unknown Object (File)
	Thu, May 30, 7:44 PM

Subscribers

Details

Reviewers

rrs
rscheff
peter.lei_ieee.org
lstewart

Group Reviewers

Commits

rGe7381521aa75: tcp: remove unused code in tcp_usr_attach

Summary

pr_attach is only called on a socket so with so->so_listen != NULL via sonewconn. However, sonewconn is not called from the TCP code. The listening sockets are handled in tcp_syncache.c without using sonewconn. Therefore, the code removed is never executed.
No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Thu, May 30, 1:04 PM

Herald added a reviewer: transport. · View Herald TranscriptThu, May 30, 1:04 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Thu, May 30, 1:04 PM

rrs accepted this revision.Thu, May 30, 3:25 PM

This revision is now accepted and ready to land.Thu, May 30, 3:25 PM

peter.lei_ieee.org accepted this revision.Thu, May 30, 3:32 PM

Closed by commit rGe7381521aa75: tcp: remove unused code in tcp_usr_attach (authored by tuexen). · Explain WhyThu, May 30, 7:41 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rGe7381521aa75: tcp: remove unused code in tcp_usr_attach.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

6 lines

Diff 139232

sys/netinet/tcp_usrreq.c

Loading...