TCP RACK, BBR: ensure return value is always ininitialized
ClosedPublic
Actions

Authored by tuexen on Dec 27 2024, 8:17 PM.

Details

Reviewers

rscheff
rrs
peter.lei_ieee.org
lstewart
cc

Group Reviewers

transport

Commits

rG60682a028156: TCP RACK, BBR: ensure return value is always ininitialized
rG0da0b392e2e4: TCP RACK, BBR: ensure return value is always ininitialized
rGb5739c8b1222: TCP RACK, BBR: ensure return value is always ininitialized

Summary

Do not return an uninitialized value from ctf_do_queued_segments() in case no packets are actually processed (all are skipped).

CID: 1523774

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Dec 27 2024, 8:17 PM

Herald added a reviewer: transport. · View Herald TranscriptDec 27 2024, 8:17 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Dec 27 2024, 8:17 PM

rrs accepted this revision.Dec 30 2024, 1:08 PM

This revision is now accepted and ready to land.Dec 30 2024, 1:08 PM

Closed by commit rGb5739c8b1222: TCP RACK, BBR: ensure return value is always ininitialized (authored by tuexen). · Explain WhyDec 30 2024, 3:05 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rGb5739c8b1222: TCP RACK, BBR: ensure return value is always ininitialized.

tuexen added a commit: rG0da0b392e2e4: TCP RACK, BBR: ensure return value is always ininitialized.Feb 5 2025, 7:43 PM

tuexen added a commit: rG60682a028156: TCP RACK, BBR: ensure return value is always ininitialized.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_stacks/

rack_bbr_common.c

2 lines

Diff 148550

View Options

sys/netinet/tcp_stacks/rack_bbr_common.c

TCP RACK, BBR: ensure return value is always ininitializedClosedPublicActions