TCP BBR: remove code not needed
ClosedPublic
Actions

Authored by tuexen on Jan 4 2025, 2:58 PM.

Details

Reviewers

rrs
rscheff
cc
peter.lei_ieee.org
lstewart

Group Reviewers

transport

Commits

rG264b7dd11fa1: TCP BBR: remove code which is not needed
rG6ab740bc90c1: TCP BBR: remove code which is not needed
rG4bce1a19fcfa: TCP BBR: remove code which is not needed

Summary

rc_bbr_substate is a 3-bit unsigned int, so it can't be larger than or equal to 8.
The wrap around already happens.
No functional change intended.
CID: 1523795

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Jan 4 2025, 2:58 PM

Herald added a reviewer: transport. · View Herald TranscriptJan 4 2025, 2:58 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Jan 4 2025, 2:58 PM

rrs accepted this revision.Jan 4 2025, 6:30 PM

This revision is now accepted and ready to land.Jan 4 2025, 6:30 PM

Closed by commit rG4bce1a19fcfa: TCP BBR: remove code which is not needed (authored by tuexen). · Explain WhyJan 4 2025, 8:11 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rG4bce1a19fcfa: TCP BBR: remove code which is not needed.

tuexen added a commit: rG6ab740bc90c1: TCP BBR: remove code which is not needed.Feb 5 2025, 8:51 PM

tuexen added a commit: rG264b7dd11fa1: TCP BBR: remove code which is not needed.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_stacks/

bbr.c

4 lines

Diff 148779

View Options

sys/netinet/tcp_stacks/bbr.c

TCP BBR: remove code not neededClosedPublicActions