Page MenuHomeFreeBSD
Differential D48001

icmp: improve INVARIANTS check
ClosedPublic
Actions

Authored by tuexen on Mon, Dec 9, 4:41 PM.
Tags
None
Referenced Files
F105560026: D48001.diff
Tue, Dec 17, 4:26 PM
Unknown Object (File)
Sat, Dec 14, 9:41 PM
Unknown Object (File)
Thu, Dec 12, 2:53 PM
Subscribers
ae
imp
melifaro

Details

Reviewers
glebius
rscheff
rrs
lstewart
peter.lei_ieee.org
cc
Commits
rGc9febea3dc8a: icmp: improve INVARIANTS check
Summary

Actually check the conditions, which are enforced by the error checking code instead of a condition which is

  • checking a number to be non-negative instead of positive
  • depending on a random number

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen created this revision.Mon, Dec 9, 4:41 PM
Herald added subscribers: melifaro, imp. · View Herald TranscriptMon, Dec 9, 4:41 PM
tuexen requested review of this revision.Mon, Dec 9, 4:41 PM
rrs accepted this revision.Mon, Dec 9, 7:54 PM
This revision is now accepted and ready to land.Mon, Dec 9, 7:54 PM
cc accepted this revision.Tue, Dec 10, 2:23 PM
cc added a comment.Tue, Dec 10, 2:26 PM

Additional comment:

% sysctl -d net.inet.icmp.icmplim_jitter
net.inet.icmp.icmplim_jitter: Random icmplim jitter adjustment limit

May document this net.inet.icmp.icmplim_jitter in ICMP(4).

glebius requested changes to this revision.Tue, Dec 10, 7:05 PM

Thanks! Please apply same changes to netinet6/icmp6.c

This revision now requires changes to proceed.Tue, Dec 10, 7:05 PM
tuexen updated this revision to Diff 147800.Tue, Dec 10, 10:29 PM

Consistently handle ICMPv4 and ICMPv6 as suggested by Gleb.

Herald added a subscriber: ae. · View Herald TranscriptTue, Dec 10, 10:29 PM
tuexen added a comment.Tue, Dec 10, 10:29 PM
In D48001#1094533, @glebius wrote:

Thanks! Please apply same changes to netinet6/icmp6.c

Done. Thanks.

tuexen added a comment.Tue, Dec 10, 11:56 PM
In D48001#1094461, @cc wrote:

Additional comment:

% sysctl -d net.inet.icmp.icmplim_jitter
net.inet.icmp.icmplim_jitter: Random icmplim jitter adjustment limit

May document this net.inet.icmp.icmplim_jitter in ICMP(4).

Improved man page in D48025.

glebius accepted this revision.Thu, Dec 12, 1:56 PM
This revision is now accepted and ready to land.Thu, Dec 12, 1:56 PM
Closed by commit rGc9febea3dc8a: icmp: improve INVARIANTS check (authored by tuexen). · Explain WhyThu, Dec 12, 2:45 PM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rGc9febea3dc8a: icmp: improve INVARIANTS check.

Revision Contents
Changeset List

PathSize
sys/
netinet/
2 lines
netinet6/
2 lines

Diff 147860

View Options

sys/netinet/ip_icmp.c

Loading...
View Options

sys/netinet6/icmp6.c

Loading...