Paths

Table of Contentst

TCP BBR: remove dead code
ClosedPublic
Actions

Authored by tuexen on Jan 4 2025, 8:51 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jul 18, 2:23 AM

	Unknown Object (File)
	Fri, Jul 17, 10:52 AM

	Unknown Object (File)
	Sat, Jul 4, 9:20 AM

	Unknown Object (File)
	Jun 9 2026, 10:37 AM

	Unknown Object (File)
	Jun 7 2026, 4:28 AM

	Unknown Object (File)
	May 11 2026, 8:21 PM

	Unknown Object (File)
	May 11 2026, 8:21 PM

	Unknown Object (File)
	May 11 2026, 8:09 PM

Subscribers

Details

Reviewers

rrs
rscheff
cc
peter.lei_ieee.org
lstewart

Group Reviewers

transport

Commits

rG7edc7c8f6f97: TCP BBR: remove dead code
rG2a704e9ca7e9: TCP BBR: remove dead code
rGc28fefe1dc44: TCP BBR: remove dead code

Summary

bw is unsigned and not zero. So it cannot be smaller than 1.
No functional change intended.
CID: 1523791

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Jan 4 2025, 8:51 PM

Herald added a reviewer: transport. · View Herald TranscriptJan 4 2025, 8:51 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Jan 4 2025, 8:51 PM

rrs accepted this revision.Jan 6 2025, 2:11 PM

This revision is now accepted and ready to land.Jan 6 2025, 2:11 PM

cc accepted this revision.Jan 6 2025, 3:19 PM

Closed by commit rGc28fefe1dc44: TCP BBR: remove dead code (authored by tuexen). · Explain WhyJan 6 2025, 7:43 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rGc28fefe1dc44: TCP BBR: remove dead code.

tuexen added a commit: rG2a704e9ca7e9: TCP BBR: remove dead code.Feb 5 2025, 8:55 PM

tuexen added a commit: rG7edc7c8f6f97: TCP BBR: remove dead code.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_stacks/

bbr.c

3 lines

Diff 148822

View Options

sys/netinet/tcp_stacks/bbr.c

TCP BBR: remove dead codeClosedPublicActions